[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 11/15] kvm: Introduce slots lock for memory l
|
From: |
Peter Xu |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 11/15] kvm: Introduce slots lock for memory listener |
|
Date: |
Tue, 21 May 2019 10:34:32 +0800 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, May 20, 2019 at 12:49:39PM +0200, Paolo Bonzini wrote:
> On 20/05/19 05:08, Peter Xu wrote:
> > +/* Must be with slots_lock held */
>
> Perhaps "Called with KVMMemoryListener slots_lock held."?
Yes sounds better. I'm replacing the old comments with "Called with
KVMMemoryListener.slots_lock held" (with the dot).
Thanks,
--
Peter Xu
- [Qemu-devel] [PATCH v2 04/15] memory: Remove memory_region_get_dirty(), (continued)
- [Qemu-devel] [PATCH v2 04/15] memory: Remove memory_region_get_dirty(), Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 05/15] memory: Don't set migration bitmap when without migration, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 02/15] linux-headers: Update to Linux 5.2-rc1, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 06/15] bitmap: Add bitmap_copy_with_{src|dst}_offset(), Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 07/15] memory: Pass mr into snapshot_and_clear_dirty, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 09/15] kvm: Update comments for sync_dirty_bitmap, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 08/15] memory: Introduce memory listener hook log_clear(), Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 10/15] kvm: Persistent per kvmslot dirty bitmap, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 11/15] kvm: Introduce slots lock for memory listener, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 12/15] kvm: Support KVM_CLEAR_DIRTY_LOG, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 13/15] qmp: Expose manual_dirty_log_protect via "query-kvm", Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 14/15] hmp: Expose manual_dirty_log_protect via "info kvm", Peter Xu, 2019/05/19