[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 13/15] qmp: Expose manual_dirty_log_protect v
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v2 13/15] qmp: Expose manual_dirty_log_protect via "query-kvm" |
Date: |
Tue, 21 May 2019 10:42:04 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, May 20, 2019 at 11:30:01AM -0500, Eric Blake wrote:
> On 5/19/19 10:08 PM, Peter Xu wrote:
> > Expose the new capability via "query-kvm" QMP command too so we know
> > whether that's turned on on the source VM when we want.
> >
> > Signed-off-by: Peter Xu <address@hidden>
> > ---
> > accel/kvm/kvm-all.c | 5 +++++
> > include/sysemu/kvm.h | 2 ++
> > qapi/misc.json | 6 +++++-
> > qmp.c | 1 +
> > 4 files changed, 13 insertions(+), 1 deletion(-)
> >
>
> > +++ b/qapi/misc.json
> > @@ -253,9 +253,13 @@
> > #
> > # @present: true if KVM acceleration is built into this executable
> > #
> > +# @manual-dirty-log-protect: true if manual dirty log protect is enabled
> > +#
>
> If we want this exposed (and Paolo is right that we might not), it needs
> '(since 4.1)' designation.
Yes I'll drop them. Still, thanks to review the grammar part (as
always).
--
Peter Xu
- Re: [Qemu-devel] [PATCH v2 11/15] kvm: Introduce slots lock for memory listener, (continued)
- [Qemu-devel] [PATCH v2 12/15] kvm: Support KVM_CLEAR_DIRTY_LOG, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 13/15] qmp: Expose manual_dirty_log_protect via "query-kvm", Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 14/15] hmp: Expose manual_dirty_log_protect via "info kvm", Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 15/15] migration: Split log_clear() into smaller chunks, Peter Xu, 2019/05/19
- Re: [Qemu-devel] [PATCH v2 00/15] kvm/migration: support KVM_CLEAR_DIRTY_LOG, Paolo Bonzini, 2019/05/20