[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 04/23] s390x/tcg: Implement VECTOR FP ADD
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v1 04/23] s390x/tcg: Implement VECTOR FP ADD |
Date: |
Fri, 31 May 2019 18:26:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 31.05.19 17:54, Richard Henderson wrote:
> On 5/31/19 5:44 AM, David Hildenbrand wrote:
>> +static uint64_t vfa64(uint64_t a, uint64_t b, float_status *s)
>> +{
>> + return float64_val(float64_add(make_float64(a), make_float64(b), s));
>> +}
>
>
> You don't need either make_float64 or float64_val.
> I've been intending to strip them out entirely; we
> don't need to add new uses.
Makes sense, I added them for consistency - will remove them.
--
Thanks,
David / dhildenb
- [Qemu-devel] [PATCH v1 01/23] s390x: Use uint64_t for vector registers, (continued)
- [Qemu-devel] [PATCH v1 09/23] s390x/tcg: Implement VECTOR FP CONVERT TO FIXED 64-BIT, David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 04/23] s390x/tcg: Implement VECTOR FP ADD, David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 10/23] s390x/tcg: Implement VECTOR FP CONVERT TO LOGICAL 64-BIT, David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 05/23] s390x/tcg: Implement VECTOR FP COMPARE (AND SIGNAL) SCALAR, David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 06/23] s390x/tcg: Implement VECTOR FP COMPARE (EQUAL|HIGH|HIGH OR EQUAL), David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 11/23] s390x/tcg: Implement VECTOR FP DIVIDE, David Hildenbrand, 2019/05/31