[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 07/23] s390x/tcg: Implement VECTOR FP CONVERT
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v1 07/23] s390x/tcg: Implement VECTOR FP CONVERT FROM FIXED 64-BIT |
Date: |
Fri, 31 May 2019 12:15:05 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 5/31/19 12:10 PM, Richard Henderson wrote:
> On 5/31/19 5:44 AM, David Hildenbrand wrote:
>> +static DisasJumpType op_vcdg(DisasContext *s, DisasOps *o)
>> +{
>> + const uint8_t fpf = get_field(s->fields, m3);
>> + const uint8_t m4 = get_field(s->fields, m4);
>> + const uint8_t erm = get_field(s->fields, m5);
>> + const bool se = extract32(m4, 3, 1);
>> + gen_helper_gvec_2_ptr *fn;
>> +
>> + if (fpf != FPF_LONG || extract32(m4, 0, 2) || erm > 7 || erm == 2) {
>
> Please split out the erm validity check.
> We have fpinst_extract_m34 doing some of this now;
> it would be a shame to replicate it more.
Hmm. Or perhaps you aren't replicating it because it's only used by these
conversions, and both signed and unsigned go through this same function?
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v1 00/23] s390x/tcg: Vector Instruction Support Part 4, David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 03/23] s390x/tcg: Export float_comp_to_cc() and float(32|64|128)_dcmask(), David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 08/23] s390x/tcg: Implement VECTOR FP CONVERT FROM LOGICAL 64-BIT, David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 01/23] s390x: Use uint64_t for vector registers, David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 02/23] s390x/tcg: Introduce tcg_s390_vector_exception(), David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 07/23] s390x/tcg: Implement VECTOR FP CONVERT FROM FIXED 64-BIT, David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 09/23] s390x/tcg: Implement VECTOR FP CONVERT TO FIXED 64-BIT, David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 04/23] s390x/tcg: Implement VECTOR FP ADD, David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 10/23] s390x/tcg: Implement VECTOR FP CONVERT TO LOGICAL 64-BIT, David Hildenbrand, 2019/05/31
- [Qemu-devel] [PATCH v1 05/23] s390x/tcg: Implement VECTOR FP COMPARE (AND SIGNAL) SCALAR, David Hildenbrand, 2019/05/31