Re: [Qemu-devel] balloon config change seems to break live migration from 3.0.1 to 4.0

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] balloon config change seems to break live migration from 
3.0.1 to 4.0

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
16eeaca balloon config change seems to break live migration from 3.0.1 to 4.0

=== OUTPUT BEGIN ===
ERROR: do not use C99 // comments
#127: FILE: hw/virtio/virtio-balloon.c:626:
+    //if (dev->free_page_report_status == FREE_PAGE_REPORT_S_REQUESTED) {

ERROR: do not use C99 // comments
#128: FILE: hw/virtio/virtio-balloon.c:627:
+    //    config.free_page_report_cmd_id =

ERROR: do not use C99 // comments
#129: FILE: hw/virtio/virtio-balloon.c:628:
+    //                   cpu_to_le32(dev->free_page_report_cmd_id);

ERROR: do not use C99 // comments
#130: FILE: hw/virtio/virtio-balloon.c:629:
+    //} else if (dev->free_page_report_status == FREE_PAGE_REPORT_S_STOP) {

ERROR: do not use C99 // comments
#131: FILE: hw/virtio/virtio-balloon.c:630:
+    //    config.free_page_report_cmd_id =

ERROR: do not use C99 // comments
#132: FILE: hw/virtio/virtio-balloon.c:631:
+    //                   cpu_to_le32(VIRTIO_BALLOON_CMD_ID_STOP);

ERROR: do not use C99 // comments
#133: FILE: hw/virtio/virtio-balloon.c:632:
+    //} else if (dev->free_page_report_status == FREE_PAGE_REPORT_S_DONE) {

ERROR: do not use C99 // comments
#134: FILE: hw/virtio/virtio-balloon.c:633:
+    //    config.free_page_report_cmd_id =

ERROR: do not use C99 // comments
#135: FILE: hw/virtio/virtio-balloon.c:634:
+    //                   cpu_to_le32(VIRTIO_BALLOON_CMD_ID_DONE);

ERROR: do not use C99 // comments
#136: FILE: hw/virtio/virtio-balloon.c:635:
+    //}

ERROR: Missing Signed-off-by: line(s)

total: 11 errors, 0 warnings, 38 lines checked

Commit 16eeaca78a15 (balloon config change seems to break live migration from 
3.0.1 to 4.0) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden