[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/25] qapi: Improve reporting of member name clashes
From: |
Eric Blake |
Subject: |
Re: [PATCH 07/25] qapi: Improve reporting of member name clashes |
Date: |
Tue, 24 Sep 2019 10:38:57 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/24/19 8:28 AM, Markus Armbruster wrote:
> We report name clashes like this:
>
> struct-base-clash.json: In struct 'Sub':
> struct-base-clash.json:5: 'name' (member of Sub) collides with 'name'
> (member of Base)
>
> The "(member of Sub)" is redundant with "In struct 'Sub'". Comes from
> QAPISchemaMember.describe(). Pass info to it, so it can detect the
> redundancy and avoid it. Result:
>
> struct-base-clash.json: In struct 'Sub':
> struct-base-clash.json:5: member 'name' collides with member 'name' of
> type 'Base'
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
The resulting error messages are indeed nicer.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 10/25] qapi: Use check_name_str() where it suffices, (continued)
- [PATCH 17/25] qapi: Move context-free checking to the proper place, Markus Armbruster, 2019/09/24
- [PATCH 11/25] qapi: Report invalid '*' prefix like any other invalid name, Markus Armbruster, 2019/09/24
- [PATCH 24/25] qapi: Improve reporting of redefinition, Markus Armbruster, 2019/09/24
- [PATCH 15/25] qapi: Inline check_name() into check_union(), Markus Armbruster, 2019/09/24
- [PATCH 07/25] qapi: Improve reporting of member name clashes, Markus Armbruster, 2019/09/24
- Re: [PATCH 07/25] qapi: Improve reporting of member name clashes,
Eric Blake <=
- [PATCH 13/25] qapi: Make check_type()'s array case a bit more obvious, Markus Armbruster, 2019/09/24
- [PATCH 18/25] qapi: Improve reporting of invalid 'if' errors, Markus Armbruster, 2019/09/24
- [PATCH 12/25] qapi: Move check for reserved names out of add_name(), Markus Armbruster, 2019/09/24
- [PATCH 22/25] qapi: Eliminate check_keys(), rename check_known_keys(), Markus Armbruster, 2019/09/24
- [PATCH 19/25] qapi: Improve reporting of invalid flags, Markus Armbruster, 2019/09/24