qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 00/14] Clean-ups: remove QDEV_PROP_PTR


From: Marc-André Lureau
Subject: [PATCH 00/14] Clean-ups: remove QDEV_PROP_PTR
Date: Fri, 18 Oct 2019 17:41:58 +0200

Hi,

QDEV_PROP_PTR is marked in multiple places as "FIXME/TODO/remove
me". In most cases, it can be easily replaced with QDEV_PROP_LINK when
the pointer points to an Object.

There are a few places where such substitution isn't possible. For
those places, it seems reasonable to use a specific setter method
instead, and keep the user_creatable = false. It is the case for OMAP
clocks, and smbus-eeprom initial data pointer. Improving that
situation is left for a future improvement.

Marc-André Lureau (14):
  sm501: replace PROP_PTR with PROP_LINK
  vmmouse: replace PROP_PTR with PROP_LINK
  lance: replace PROP_PTR with PROP_LINK
  etraxfs: remove PROP_PTR usage
  dp8393x: replace PROP_PTR with PROP_LINK
  leon3: replace PROP_PTR with PROP_LINK
  RFC: mips/cps: fix setting saar property
  cris: replace PROP_PTR with PROP_LINK for interrupt vector
  smbus-eeprom: remove PROP_PTR
  omap-intc: remove PROP_PTR
  omap-i2c: remove PROP_PTR
  omap-gpio: remove PROP_PTR
  qdev: remove PROP_MEMORY_REGION
  Remove QDEV_PROP_PTR

 hw/arm/omap1.c               |  8 +++----
 hw/arm/omap2.c               | 25 ++++++++++-----------
 hw/core/qdev-properties.c    | 18 ----------------
 hw/cris/axis_dev88.c         |  4 +---
 hw/display/sm501.c           |  5 +++--
 hw/dma/sparc32_dma.c         |  2 +-
 hw/gpio/omap_gpio.c          | 42 +++++++++++++-----------------------
 hw/i2c/omap_i2c.c            | 19 ++++++++++------
 hw/i2c/smbus_eeprom.c        | 17 +++++++--------
 hw/i386/pc.c                 |  6 +++---
 hw/i386/vmmouse.c            |  8 +++----
 hw/input/pckbd.c             |  8 +++----
 hw/intc/Makefile.objs        |  2 +-
 hw/intc/etraxfs_pic.c        | 18 ++++++----------
 hw/intc/grlib_irqmp.c        | 20 ++++++-----------
 hw/intc/omap_intc.c          | 17 +++++++++------
 hw/mips/cps.c                |  2 +-
 hw/mips/mips_jazz.c          |  3 ++-
 hw/net/dp8393x.c             |  7 +++---
 hw/net/etraxfs_eth.c         | 35 ++++++++++++++++++++----------
 hw/net/lance.c               |  5 ++---
 hw/net/pcnet-pci.c           |  2 +-
 hw/net/pcnet.h               |  2 +-
 hw/sh4/r2d.c                 |  3 ++-
 hw/sparc/leon3.c             |  7 +++---
 include/hw/arm/omap.h        | 36 +++++++++++++++++++++++++++++++
 include/hw/cris/etraxfs.h    | 20 +++--------------
 include/hw/input/i8042.h     |  4 +++-
 include/hw/qdev-properties.h | 24 ---------------------
 target/sparc/cpu.h           |  1 +
 30 files changed, 172 insertions(+), 198 deletions(-)

-- 
2.23.0.606.g08da6496b6




reply via email to

[Prev in Thread] Current Thread [Next in Thread]