[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/14] lance: replace PROP_PTR with PROP_LINK
From: |
Peter Maydell |
Subject: |
Re: [PATCH 03/14] lance: replace PROP_PTR with PROP_LINK |
Date: |
Mon, 21 Oct 2019 11:05:03 +0100 |
On Fri, 18 Oct 2019 at 16:42, Marc-André Lureau
<address@hidden> wrote:
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> hw/dma/sparc32_dma.c | 2 +-
> hw/net/lance.c | 5 ++---
> hw/net/pcnet-pci.c | 2 +-
> hw/net/pcnet.h | 2 +-
> 4 files changed, 5 insertions(+), 6 deletions(-)
I feel like there's probably a way to be more type-safe here
(eg for the lance.c property we know the linked device must
be TYPE_SPARC32_LEDMA_DEVICE, not just TYPE_DEVICE), but I guess
this will do.
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [PATCH 00/14] Clean-ups: remove QDEV_PROP_PTR, Marc-André Lureau, 2019/10/18
- [PATCH 02/14] vmmouse: replace PROP_PTR with PROP_LINK, Marc-André Lureau, 2019/10/18
- [PATCH 03/14] lance: replace PROP_PTR with PROP_LINK, Marc-André Lureau, 2019/10/18
- Re: [PATCH 03/14] lance: replace PROP_PTR with PROP_LINK,
Peter Maydell <=
- [PATCH 04/14] etraxfs: remove PROP_PTR usage, Marc-André Lureau, 2019/10/18
- Re: [PATCH 04/14] etraxfs: remove PROP_PTR usage, Peter Maydell, 2019/10/21
[PATCH 05/14] dp8393x: replace PROP_PTR with PROP_LINK, Marc-André Lureau, 2019/10/18
[PATCH 06/14] leon3: replace PROP_PTR with PROP_LINK, Marc-André Lureau, 2019/10/18