[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 02/40] target/arm: Enable HCR_E2H for VHE
From: |
Richard Henderson |
Subject: |
[PATCH v4 02/40] target/arm: Enable HCR_E2H for VHE |
Date: |
Mon, 2 Dec 2019 18:28:59 -0800 |
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/arm/cpu.h | 7 -------
target/arm/helper.c | 6 +++++-
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index 994cad2014..9729e62d2c 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -1387,13 +1387,6 @@ static inline void xpsr_write(CPUARMState *env, uint32_t
val, uint32_t mask)
#define HCR_ATA (1ULL << 56)
#define HCR_DCT (1ULL << 57)
-/*
- * When we actually implement ARMv8.1-VHE we should add HCR_E2H to
- * HCR_MASK and then clear it again if the feature bit is not set in
- * hcr_write().
- */
-#define HCR_MASK ((1ULL << 34) - 1)
-
#define SCR_NS (1U << 0)
#define SCR_IRQ (1U << 1)
#define SCR_FIQ (1U << 2)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 0bf8f53d4b..d81daadf45 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -4672,7 +4672,8 @@ static const ARMCPRegInfo el3_no_el2_v8_cp_reginfo[] = {
static void hcr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value)
{
ARMCPU *cpu = env_archcpu(env);
- uint64_t valid_mask = HCR_MASK;
+ /* Begin with bits defined in base ARMv8.0. */
+ uint64_t valid_mask = MAKE_64BIT_MASK(0, 34);
if (arm_feature(env, ARM_FEATURE_EL3)) {
valid_mask &= ~HCR_HCD;
@@ -4686,6 +4687,9 @@ static void hcr_write(CPUARMState *env, const
ARMCPRegInfo *ri, uint64_t value)
*/
valid_mask &= ~HCR_TSC;
}
+ if (cpu_isar_feature(aa64_vh, cpu)) {
+ valid_mask |= HCR_E2H;
+ }
if (cpu_isar_feature(aa64_lor, cpu)) {
valid_mask |= HCR_TLOR;
}
--
2.17.1
- [PATCH v4 00/40] target/arm: Implement ARMv8.1-VHE, Richard Henderson, 2019/12/02
- [PATCH v4 01/40] target/arm: Define isar_feature_aa64_vh, Richard Henderson, 2019/12/02
- [PATCH v4 02/40] target/arm: Enable HCR_E2H for VHE,
Richard Henderson <=
- [PATCH v4 03/40] target/arm: Add CONTEXTIDR_EL2, Richard Henderson, 2019/12/02
- [PATCH v4 04/40] target/arm: Add TTBR1_EL2, Richard Henderson, 2019/12/02
- [PATCH v4 05/40] target/arm: Update CNTVCT_EL0 for VHE, Richard Henderson, 2019/12/02
- [PATCH v4 06/40] target/arm: Split out vae1_tlbmask, vmalle1_tlbmask, Richard Henderson, 2019/12/02
- [PATCH v4 11/40] target/arm: Rename ARMMMUIdx_S1SE* to ARMMMUIdx_SE*, Richard Henderson, 2019/12/02