[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/8] Fix Exynos4210 DMA support
From: |
Guenter Roeck |
Subject: |
Re: [PATCH v3 0/8] Fix Exynos4210 DMA support |
Date: |
Thu, 23 Jan 2020 07:39:41 -0800 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Thu, Jan 23, 2020 at 03:20:48PM +0000, Peter Maydell wrote:
> On Thu, 23 Jan 2020 at 05:25, Guenter Roeck <address@hidden> wrote:
> >
> > Commit 59520dc65e ("hw/arm/exynos4210: Add DMA support for the Exynos4210")
> > introduced DMA support for Exynos4210. Unfortunately, it never really
> > worked. DMA interrupt line and polarity was wrong, and the serial port
> > needs extra code to support DMA. This patch series fixes the problem.
> >
> > The series also converts pl330 and exynos4210_uart code to support tracing.
> > While not strictly necessary, this was very useful for debugging,
> > and it seemed too valuable to drop it from the final series. Similar,
> > improved support for receive FIFO handling is not strictly necessary
> > to fix DMA handling, but I initially thought that it was and added the
> > code. Like tracing support it seemed too valuable to drop it.
> >
> > The series was tested with qemu's smdkc210 and nuri emulations and with
> > exynos4210-smdkv310.dtb. Without the series, the emulation does not react
> > to serial line input, and serial line output stalls when using DMA. With
> > this series in place, serial line input is handled correctly, serial
> > output does not stall, and DMA interrupts are observed and handled.
>
> Applied to target-arm.next, thanks.
>
Thanks a lot for your help!
Guenter
- Re: [PATCH v3 1/8] dma/pl330: Convert to support tracing, (continued)
[PATCH v3 3/8] hw/arm/exynos4210: Fix DMA initialization, Guenter Roeck, 2020/01/23
[PATCH v3 5/8] hw/char/exynos4210_uart: Implement post_load function, Guenter Roeck, 2020/01/23
[PATCH v3 4/8] hw/char/exynos4210_uart: Convert to support tracing, Guenter Roeck, 2020/01/23
[PATCH v3 6/8] hw/char/exynos4210_uart: Implement Rx FIFO level triggers and timeouts, Guenter Roeck, 2020/01/23
[PATCH v3 8/8] hw/arm/exynos4210: Connect serial port DMA busy signals with pl330, Guenter Roeck, 2020/01/23
[PATCH v3 7/8] hw/char/exynos4210_uart: Add receive DMA support, Guenter Roeck, 2020/01/23
Re: [PATCH v3 0/8] Fix Exynos4210 DMA support, Peter Maydell, 2020/01/23
- Re: [PATCH v3 0/8] Fix Exynos4210 DMA support,
Guenter Roeck <=