[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] audio: proper support for float samples in mixeng
From: |
Markus Armbruster |
Subject: |
Re: [RFC PATCH] audio: proper support for float samples in mixeng |
Date: |
Tue, 04 Feb 2020 07:48:12 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 2/3/20 12:21 AM, Markus Armbruster wrote:
>> "Kővágó, Zoltán" <address@hidden> writes:
>>
>>> This adds proper support for float samples in mixeng by adding a new
>>> audio format for it.
>>>
>>> Limitations: only native endianness is supported.
>>>
>>> Signed-off-by: Kővágó, Zoltán <address@hidden>
>>> ---
>>>
>>> This patch is meant to be applied on top of "[PATCH] coreaudio: fix
>>> coreaudio
>>> playback" by Volker Rümelin, available at:
>>> https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg00114.html
>>>
>>> For more information, please refer to that thread.
>>>
>>> ---
>
>>> +++ b/qapi/audio.json
>>> @@ -276,7 +276,7 @@
>>> # Since: 4.0
>>> ##
>>> { 'enum': 'AudioFormat',
>>> - 'data': [ 'u8', 's8', 'u16', 's16', 'u32', 's32' ] }
>>> + 'data': [ 'u8', 's8', 'u16', 's16', 'u32', 's32', 'f32' ] }
>>> ##
>>> # @AudiodevDriver:
>>
>> For QAPI:
>> Acked-by: Markus Armbruster <address@hidden>
>
> Is it worth a comment update mentioning that 'f32' is '(since 5.0)'?
Good point; we routinely do that.
Should look like this:
##
# @AudioFormat:
#
# An enumeration of possible audio formats.
#
# @u8: lorem
# @s8: ipsum
# @u16: dolor
# @s16: sit
# @u32: amet
# @s32: consectetur
# @f32: adipisici (since 5.0)
#
# Since: 4.0
##
The generator does not enforce documentation of enum values.