[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 19/33] raw-format: Split raw_read_options()

From: Eric Blake
Subject: Re: [PATCH v2 19/33] raw-format: Split raw_read_options()
Date: Wed, 5 Feb 2020 15:57:22 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/4/20 11:08 AM, Max Reitz wrote:
Split raw_read_options() into one function that actually just reads the
options, and another that applies them.  This will allow us to detect
whether the user has specified any options before attaching the file
child (so we can decide on its role based on the options).

Signed-off-by: Max Reitz <address@hidden>
  block/raw-format.c | 110 ++++++++++++++++++++++++++-------------------
  1 file changed, 65 insertions(+), 45 deletions(-)

Looks like a useful split.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]