[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 22/33] block: Make backing files child_of_bds children

From: Max Reitz
Subject: Re: [PATCH v2 22/33] block: Make backing files child_of_bds children
Date: Thu, 6 Feb 2020 12:33:44 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 05.02.20 23:45, Eric Blake wrote:
> On 2/4/20 11:08 AM, Max Reitz wrote:
>> Signed-off-by: Max Reitz <address@hidden>
> Another sparse commit message (a recurring theme of this series). The
> subject line says 'what', and the patch appears to be faithful to that,
> but if a future bisection lands here, even a one-sentence 'why' would be
> handy; maybe:
> This is part of a larger series of unifying block device relationships
> via child_of_bds.

Sure, works for me.  Or maybe:

Make all parents of backing files pass the appropriate BdrvChildRole.
By doing so, we can switch their BdrvChildClass over to the generic
child_of_bds, which will do the right thing when given a correct

(Because actually the point of this series is not child_of_bds, but the
BdrvChildRole, which allows the “Deal with filters” series to implement
the child access functions in a more obvious way.  I hope.)


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]