[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/4] Add the NVMM acceleration enlightenments

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 4/4] Add the NVMM acceleration enlightenments
Date: Thu, 6 Feb 2020 17:07:21 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/6/20 4:38 PM, Kamil Rytarowski wrote:
On 06.02.2020 15:13, Markus Armbruster wrote:
Kamil Rytarowski <address@hidden> writes:

On 06.02.2020 14:09, Philippe Mathieu-Daudé wrote:
On Thu, Feb 6, 2020 at 2:06 PM Markus Armbruster <address@hidden> wrote:
Kamil Rytarowski <address@hidden> writes:

On 03.02.2020 12:54, Philippe Mathieu-Daudé wrote:
@@ -2029,6 +2072,19 @@ static void qemu_whpx_start_vcpu(CPUState *cpu)

+static void qemu_nvmm_start_vcpu(CPUState *cpu)
+    char thread_name[VCPU_THREAD_NAME_SIZE];
+    cpu->thread = g_malloc0(sizeof(QemuThread));
+    cpu->halt_cond = g_malloc0(sizeof(QemuCond));

Nitpick, we prefer g_new0().

In this file other qemu_*_start_vcpu() use  g_malloc0().

I will leave this part unchanged and defer tor future style fixups if
someone is interested.

Time to re-run Coccinelle with the semantic patch from commit

I thought about it, but then noticed it would be clever to modify
checkpatch to refuse 'g_malloc0?(.*sizeof.*);'

As the patchset was reviewed, could we please merge it in the current
(v3) form (*) please?

No objection.  If I wanted you to clean this up before we accept your
work, I would've told you :)


I see. I don't own myself a merge queue so I depend on yours.

As you said [*] you'd love to have this feature in NetBSD 9.0, no objection neither. You still need some X86 specialist to review patch 3. The usual reviewers Paolo/Eduardo/Richard are currently very busy.

Also while I'd love to use this feature to be able to regularly run QEMU CI on NetBSD, I don't have time to test it on a bare metal hardware :|
Maybe do you know someone from the NetBSD community who already did?

[*] https://www.mail-archive.com/address@hidden/msg676199.html

reply via email to

[Prev in Thread] Current Thread [Next in Thread]