[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

From: Peter Maydell
Subject: Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs
Date: Fri, 7 Feb 2020 16:26:53 +0000

On Fri, 7 Feb 2020 at 08:37, Thomas Huth <address@hidden> wrote:
> Question to Peter/Alex/Stefan/Howevermergespullreqsinthefuture:
> Should the above jobs really be skipped for pull requests, or would it
> be ok to include them there, too? (in the latter case, the above changes
> could just be dropped)

I don't mind, as long as the CI run doesn't take more than (say)
1h to 1h30 elapsed time to complete from kicking it off to getting
all the results back. The specific set of x86 configs tested don't
really worry me (as long as we do have a reasonable spread):
the thing I really care about is that we get the multiple
host architectures and the BSDs into the test setup. (We already
have about five different ways of doing CI testing of x86 Linux
hosts, which is the least likely setup to break. It's the
other host configs that I'm really keen to see progress on
automation of, because that's what's really blocking us from
being able to move off my hand-coded scripting.)

In the long run we should probably aim for being consistent about
what we test between the pull-request tests and whatever the
'public-facing CI' part is.

> > +ubuntu-18.04.3-x86_64-notcg:
> > + tags:
> > + - ubuntu_18.04.3
> > + - x86_64
> > + rules:
> > + - if: '$CI_COMMIT_REF_NAME == "staging"'
> > + script:
> > + # 
> > https://git.linaro.org/people/peter.maydell/misc-scripts.git/tree/remake-merge-builds#n35
> > + - ./configure --disable-libssh --enable-debug --disable-tcg
> > + # 
> > https://git.linaro.org/people/peter.maydell/misc-scripts.git/tree/pull-buildtest#n35
> > + - make
> > + # 
> > https://git.linaro.org/people/peter.maydell/misc-scripts.git/tree/pull-buildtest#n39
> > + # Question: check is disabled on the original script, because the machine
> > + # is said to be running VirtualBox.  Should this be dropped or should the
> > + # machine be tweaked or substituted?
> > + - make check V=1
> Without TCG, you definitely need a host that can do KVM for running make
> check.
> Question for Peter: Would it be ok to drop this job and simply always
> use the "build-tcg-disabled" job that is already available in
> .gitlab-ci.yml ?

If we have a CI setup where KVM reliably works then we should
ideally test a --disable-tcg setup somehow. Right now my pullreq
tests don't test that because I run them on my work desktop box
and (as the config says) sometimes I'm running VirtualBox which
causes KVM to fail -- but that should be irrelevant to our CI

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]