[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

From: Peter Maydell
Subject: Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs
Date: Sat, 8 Feb 2020 12:51:10 +0000

On Fri, 7 Feb 2020 at 19:27, Cleber Rosa <address@hidden> wrote:
> On Fri, Feb 07, 2020 at 04:26:53PM +0000, Peter Maydell wrote:
> > If we have a CI setup where KVM reliably works then we should
> > ideally test a --disable-tcg setup somehow. Right now my pullreq
> > tests don't test that because I run them on my work desktop box
> > and (as the config says) sometimes I'm running VirtualBox which
> > causes KVM to fail -- but that should be irrelevant to our CI
> > runners...

> You got me confused here Peter.  Do you intend to reuse the same
> machines you're using now (say your work desktop box) or is there an
> expectation for different machines to be introduced and used for these
> jobs?

No, I specifically don't want the CI jobs to be running on my
work desktop, because that use of private-to-me machines is
one of the things that's blocking us from passing the pullreq
handling to a wider group of people.

The thing I was trying to say was that the reason why current
pullreq testing doesn't include a --disable-tcg is a pure
accident of the setup it's running in, not a deliberate decision
that we should not be testing that config. It would be better if we
did test it, and if the new CI setup allows us to test it then we

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]