[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/7] commit: Inline commit_populate()

From: Ján Tomko
Subject: Re: [PATCH 4/7] commit: Inline commit_populate()
Date: Sun, 16 Feb 2020 22:46:18 +0100

On Fri, Feb 14, 2020 at 09:08:09PM +0100, Kevin Wolf wrote:
commit_populate() is a very short function and only called in a single
place. Its return value doesn't tell us whether an error happened while
reading or writing, which would be necessary for sending the right data
in the BLOCK_JOB_ERROR QMP event.

Signed-off-by: Kevin Wolf <address@hidden>
block/commit.c | 28 ++++++----------------------
1 file changed, 6 insertions(+), 22 deletions(-)

Reviewed-by: Ján Tomko <address@hidden>


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]