qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 03/10] tests/vm: increased max timeout for vm boot.


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v1 03/10] tests/vm: increased max timeout for vm boot.
Date: Mon, 2 Mar 2020 19:32:02 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 3/2/20 7:19 PM, Alex Bennée wrote:
From: Robert Foley <address@hidden>

Add change to increase timeout waiting for VM to boot.
Needed for some emulation cases where it can take longer
than 5 minutes to boot.

Signed-off-by: Robert Foley <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Peter Puhov <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
---
  tests/vm/basevm.py | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index c99725b8c0d..5ca445e29af 100644
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -57,6 +57,10 @@ class BaseVM(object):
      poweroff = "poweroff"
      # enable IPv6 networking
      ipv6 = True
+    # Scale up some timeouts under TCG.
+    # 4 is arbitrary, but greater than 2,
+    # since we found we need to wait more than twice as long.
+    tcg_ssh_timeout_multiplier = 4
      def __init__(self, debug=False, vcpus=None):
          self._guest = None
          self._tmpdir = os.path.realpath(tempfile.mkdtemp(prefix="vm-test-",
@@ -309,6 +313,9 @@ class BaseVM(object):
          sys.stderr.write("### %s ...\n" % text)
def wait_ssh(self, seconds=300):
+        # Allow more time for VM to boot under TCG.
+        if not kvm_available(self.arch):
+            seconds *= self.tcg_ssh_timeout_multiplier
          starttime = datetime.datetime.now()
          endtime = starttime + datetime.timedelta(seconds=seconds)
          guest_up = False


A clean way might be to use a QMP socket and poll for networking events, then start counting when the network is up.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]