Re: [PATCH v1 07/10] configure: fix check for libzstd

[Alex Bennée]

Juan Quintela <address@hidden> writes:

> Alex Bennée <address@hidden> wrote:
>> Alex Bennée <address@hidden> writes:
>>
>>> Fixes: 3a67848134d0
>>> Signed-off-by: Alex Bennée <address@hidden>
>>> ---
>>>  configure | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 7b373bc0bb8..caa65f58831 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -2464,7 +2464,7 @@ fi
>>>  # zstd check
>>>  
>>>  if test "$zstd" != "no" ; then
>>> -    if $pkg_config --exist libzstd ; then
>>> +    if $pkg_config --exists libzstd ; then
>
> Hi
>
> several things:
>
> a- I found why I didn't get the error.  Fedora pkg-config is really
> "smart":
>
> b- I have tried (with this patch), the following configurations:
>    * --enable-zstd
>    * --disable-zstd
>    with both libzstd-devel installed and not installed. Everything
>    worked as expected.
>    (BTW, I tested that before submmiting the patch in the first place, I
>    thought that I had done all testing needed for such a check).
>
> Can you told me what architecture/distro/os are you using.

It broke on the CI setup - it could be another issue with the ageing
Travis images (Ubuntu 16.04).

>> Dropping this patch as it breaks the build even more!
>>
>>   CC      migration/block.o
>>
>> /home/travis/build/stsquad/qemu/migration/multifd-zstd.c:24:5: error: 
>> unknown type name ‘ZSTD_CStream’
>>
>>      ZSTD_CStream *zcs;
>>
>>      ^
>
> This is really weird.  if you arrive here, that means:
> - you have zstd devel installed (whatever is that called for your
>   os/distro/whatever).

Well it detected it:

  zstd support      yes

>
> - pkg-config has found zstd devel packages and configured them (that
>   file depends on CONFiG_ZSTD beoing defined)
>
> - gcc has found <zstd.h> (i.e. it don't give one error about that
>   include file not found).
>
> And zstd don't have ZSTD_CStream defined?  What is going on here?
> Can you post/show what is on your zstd.h file?
> What zstd library version do you have?
>
> I thought that zstd was a new library, and that we didn't need to check
> for versions.  It appears that I was wrong.  And no, the include file
> don't show what features are new/old.

Obviously not that new but has changed since it first got introduced.

-- 
Alex Bennée