[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 01/10] tests/vm: use $(PYTHON) consistently
From: |
Alex Bennée |
Subject: |
Re: [PATCH v1 01/10] tests/vm: use $(PYTHON) consistently |
Date: |
Mon, 02 Mar 2020 18:41:21 +0000 |
User-agent: |
mu4e 1.3.9; emacs 27.0.90 |
Philippe Mathieu-Daudé <address@hidden> writes:
> On 3/2/20 7:18 PM, Alex Bennée wrote:
>> From: Robert Foley <address@hidden>
>> Change Makefile.include to use $(PYTHON) so for vm-boot-ssh to be
>> consistent with other cases like vm-build.
>
> So what you are trying to fix here is when you have two python3
> installed (one from the distribution and one manually built), and you
> want to use the manually built?
No - just consistency with the rest of the build system.
>
>> Signed-off-by: Robert Foley <address@hidden>
>> Reviewed-by: Alex Bennée <address@hidden>
>> Reviewed-by: Peter Puhov <address@hidden>
>> Signed-off-by: Alex Bennée <address@hidden>
>> Message-Id: <address@hidden>
>> ---
>> tests/vm/Makefile.include | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
>> index 9e7c46a4735..778e5067554 100644
>> --- a/tests/vm/Makefile.include
>> +++ b/tests/vm/Makefile.include
>> @@ -80,7 +80,7 @@ vm-boot-serial-%: $(IMAGES_DIR)/%.img
>> vm-boot-ssh-%: $(IMAGES_DIR)/%.img
>> $(call quiet-command, \
>> - $(SRC_PATH)/tests/vm/$* \
>> + $(PYTHON) $(SRC_PATH)/tests/vm/$* \
>> $(if $(J),--jobs $(J)) \
>> --image "$<" \
>> --interactive \
>>
--
Alex Bennée
- [PATCH v1 00/10] testing/next updates (tweaks and re-greening), Alex Bennée, 2020/03/02
- [PATCH v1 02/10] tests/vm: Debug mode shows ssh output., Alex Bennée, 2020/03/02
- [PATCH v1 06/10] travis: enable tools build on OS X, Alex Bennée, 2020/03/02
- [PATCH v1 09/10] tests/acceptance: move @skipUnless decoration to test itself, Alex Bennée, 2020/03/02
- [PATCH v1 08/10] configure: detect and report genisoimage, Alex Bennée, 2020/03/02
- [PATCH v1 07/10] configure: fix check for libzstd, Alex Bennée, 2020/03/02