[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] block/nbd-client: drop max_block restriction from block_

From: Eric Blake
Subject: Re: [PATCH 1/5] block/nbd-client: drop max_block restriction from block_status
Date: Mon, 2 Mar 2020 14:53:02 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/2/20 4:05 AM, Vladimir Sementsov-Ogievskiy wrote:
NBD spec is updated, so that max_block doesn't relate to
NBD_CMD_BLOCK_STATUS. So, drop the restriction.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
  block/nbd.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/block/nbd.c b/block/nbd.c
index 976be76647..2a58d6b91c 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -1320,9 +1320,7 @@ static int coroutine_fn nbd_client_co_block_status(
      NBDRequest request = {
          .type = NBD_CMD_BLOCK_STATUS,
          .from = offset,
-                                                bs->bl.request_alignment),
-                                s->info.max_block),
+        .len = MIN(QEMU_ALIGN_DOWN(INT_MAX, bs->bl.request_alignment),
                     MIN(bytes, s->info.size - offset)),

Reviewed-by: Eric Blake <address@hidden>

We're still capped at 32 bits (instead of status over the entire device), but future NBD extensions will get to that. In the meantime, this is a lot nicer than having to stick to 32M per request.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]