[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] block/nbd-client: drop max_block restriction from discar

From: Eric Blake
Subject: Re: [PATCH 2/5] block/nbd-client: drop max_block restriction from discard
Date: Mon, 2 Mar 2020 14:53:48 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/2/20 4:05 AM, Vladimir Sementsov-Ogievskiy wrote:
NBD spec is updated, so that max_block doesn't relate to
NBD_CMD_TRIM. So, drop the restriction.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
  block/nbd.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/block/nbd.c b/block/nbd.c
index 2a58d6b91c..a62761ea5a 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -1955,7 +1955,6 @@ static void nbd_refresh_limits(BlockDriverState *bs, 
Error **errp)
bs->bl.request_alignment = min;
-    bs->bl.max_pdiscard = max;

We should still tell the block layer that we have a 32-bit cap (in case the block layer starts supporting 64-bit discard).

      bs->bl.max_pwrite_zeroes = max;
      bs->bl.max_transfer = max;

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]