Re: [PATCH] audio: Add sndio backend

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] audio: Add sndio backend
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
421ab62 audio: Add sndio backend

=== OUTPUT BEGIN ===
ERROR: space prohibited before that close parenthesis ')'
#41: FILE: audio/audio.c:1977:
+        CASE(SNDIO, sndio, );

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

ERROR: g_free(NULL) is safe this check is probably not required
#381: FILE: audio/sndioaudio.c:318:
+    if (self->pfds) {
+        g_free(self->pfds);

ERROR: g_free(NULL) is safe this check is probably not required
#386: FILE: audio/sndioaudio.c:323:
+    if (self->pindexes) {
+        g_free(self->pindexes);

ERROR: g_free(NULL) is safe this check is probably not required
#391: FILE: audio/sndioaudio.c:328:
+    if (self->buf) {
+        g_free(self->buf);

total: 4 errors, 1 warnings, 780 lines checked

Commit 421ab62c169b (audio: Add sndio backend) has style problems, please 
review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden