Re: [PATCH] audio: Add sndio backend

[Gerd Hoffmann]

On Wed, Mar 04, 2020 at 07:04:07AM -0800, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Subject: [PATCH] audio: Add sndio backend
> Message-id: address@hidden
> Type: series
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> From https://github.com/patchew-project/qemu
>  * [new tag]         patchew/address@hidden -> patchew/address@hidden
> Switched to a new branch 'test'
> 421ab62 audio: Add sndio backend
> 
> === OUTPUT BEGIN ===
> ERROR: space prohibited before that close parenthesis ')'
> #41: FILE: audio/audio.c:1977:
> +        CASE(SNDIO, sndio, );

False positive I'd say.

> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

Adding an entry to the MAINTAINERS file is a good idea though.

> ERROR: g_free(NULL) is safe this check is probably not required
> #381: FILE: audio/sndioaudio.c:318:
> +    if (self->pfds) {
> +        g_free(self->pfds);

Reasonable too.

cheers,
  Gerd