qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 09/13] migration/ram: Consolidate variable reset after pla


From: David Hildenbrand
Subject: Re: [PATCH v3 09/13] migration/ram: Consolidate variable reset after placement in ram_load_postcopy()
Date: Fri, 6 Mar 2020 20:09:32 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 06.03.20 17:30, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (address@hidden) wrote:
>> Let's consolidate resetting the variables.
>>
>> Cc: "Dr. David Alan Gilbert" <address@hidden>
>> Cc: Juan Quintela <address@hidden>
>> Cc: Peter Xu <address@hidden>
>> Signed-off-by: David Hildenbrand <address@hidden>
> 
> Thanks, I think that's actually fixing a case where huge zero pages
> weren't placed as zero pages?

I don't see it :) Can you point out in which receive sequence it would
go wrong?

We used to set "all_zero = true" when processing the first sub-page.
Now, we set "all_zero = true" before we start to process the first sub-page.

Thanks!

-- 
Thanks,

David / dhildenb




reply via email to

[Prev in Thread] Current Thread [Next in Thread]