[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/13] migration/ram: Consolidate variable reset after pla
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [PATCH v3 09/13] migration/ram: Consolidate variable reset after placement in ram_load_postcopy() |
|
Date: |
Fri, 6 Mar 2020 19:11:59 +0000 |
|
User-agent: |
Mutt/1.13.3 (2020-01-12) |
* David Hildenbrand (address@hidden) wrote:
> On 06.03.20 17:30, Dr. David Alan Gilbert wrote:
> > * David Hildenbrand (address@hidden) wrote:
> >> Let's consolidate resetting the variables.
> >>
> >> Cc: "Dr. David Alan Gilbert" <address@hidden>
> >> Cc: Juan Quintela <address@hidden>
> >> Cc: Peter Xu <address@hidden>
> >> Signed-off-by: David Hildenbrand <address@hidden>
> >
> > Thanks, I think that's actually fixing a case where huge zero pages
> > weren't placed as zero pages?
>
> I don't see it :) Can you point out in which receive sequence it would
> go wrong?
>
> We used to set "all_zero = true" when processing the first sub-page.
> Now, we set "all_zero = true" before we start to process the first sub-page.
No, you're right - no change.
Dave
> Thanks!
>
> --
> Thanks,
>
> David / dhildenb
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK