Re: [PULL 00/29] Block layer patches

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/29] Block layer patches
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
32121e1 block: bdrv_reopen() with backing file in different AioContext
b4fc54d iotests: Refactor blockdev-reopen test for iothreads
2d8f428 block/rbd: Add support for ceph namespaces
b316a0b qemu-storage-daemon: Add --monitor option
caf92c2 monitor: Add allow_hmp parameter to monitor_init()
73480ad hmp: Fail gracefully if chardev is already in use
1a7c874 qmp: Fail gracefully if chardev is already in use
f7fbb53 monitor: Create QAPIfied monitor_init()
85141e5 qapi: Create 'pragma' module
5012797 stubs: Update monitor stubs for qemu-storage-daemon
a32e4ac qemu-storage-daemon: Add --chardev option
2a264c4 qemu-storage-daemon: Add main loop
0f2bb9d qemu-storage-daemon: Add --export option
95f79fa blockdev-nbd: Boxed argument type for nbd-server-add
c3e93ca qemu-storage-daemon: Add --nbd-server option
2a54241 qemu-storage-daemon: Add --object option
b3767de qapi: Flatten object-add
40c88aa qemu-storage-daemon: Add --blockdev option
f52856a block: Move sysemu QMP commands to QAPI block module
280af2e block: Move common QMP commands to block-core QAPI module
223169a block: Move system emulator QMP commands to block/qapi-sysemu.c
c687d45 stubs: Add arch_type
1ca4df6 qemu-storage-daemon: Add barebone tool
e148d2c block/qcow2: Move bitmap reopen into bdrv_reopen_commit_post
90ceeb8 block: Introduce 'bdrv_reopen_commit_post' step
f82447c block: Fix leak in bdrv_create_file_fallback()
6c79b95 iotests/026: Test EIO on allocation in a data-file
ce45c2f iotests/026: Test EIO on preallocated zero cluster
6fe3d12 qcow2: Fix alloc_cluster_abort() for pre-existing clusters

=== OUTPUT BEGIN ===
1/29 Checking commit 6fe3d1204d78 (qcow2: Fix alloc_cluster_abort() for 
pre-existing clusters)
2/29 Checking commit ce45c2f906d8 (iotests/026: Test EIO on preallocated zero 
cluster)
3/29 Checking commit 6c79b9543536 (iotests/026: Test EIO on allocation in a 
data-file)
4/29 Checking commit f82447c66adc (block: Fix leak in 
bdrv_create_file_fallback())
5/29 Checking commit 90ceeb8bb6dc (block: Introduce 'bdrv_reopen_commit_post' 
step)
6/29 Checking commit e148d2cd2ef4 (block/qcow2: Move bitmap reopen into 
bdrv_reopen_commit_post)
7/29 Checking commit 1ca4df6e0c59 (qemu-storage-daemon: Add barebone tool)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 142 lines checked

Patch 7/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/29 Checking commit c687d45eee38 (stubs: Add arch_type)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 16 lines checked

Patch 8/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/29 Checking commit 223169a6a829 (block: Move system emulator QMP commands to 
block/qapi-sysemu.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#258: FILE: block/qapi-sysemu.c:222:
+        /* For tray-less devices, blockdev-open-tray is a no-op (or may not be

WARNING: Block comments use a trailing */ on a separate line
#261: FILE: block/qapi-sysemu.c:225:
+         * value passed here (i.e. false). */

WARNING: Block comments use a leading /* on a separate line
#305: FILE: block/qapi-sysemu.c:269:
+        /* For tray-less devices, blockdev-close-tray is a no-op (or may not be

WARNING: Block comments use a trailing */ on a separate line
#309: FILE: block/qapi-sysemu.c:273:
+         * value passed here (i.e. true). */

WARNING: Block comments use a leading /* on a separate line
#442: FILE: block/qapi-sysemu.c:406:
+    /* If the medium has been inserted, the device has its own reference, so

WARNING: Block comments use a trailing */ on a separate line
#444: FILE: block/qapi-sysemu.c:408:
+     * the reference must be relinquished anyway */

WARNING: Block comments use a leading /* on a separate line
#551: FILE: block/qapi-sysemu.c:515:
+        /* Enable I/O limits if they're not enabled yet, otherwise

WARNING: Block comments use a trailing */ on a separate line
#552: FILE: block/qapi-sysemu.c:516:
+         * just update the throttling group. */

total: 0 errors, 9 warnings, 1187 lines checked

Patch 9/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/29 Checking commit 280af2e20a90 (block: Move common QMP commands to 
block-core QAPI module)
11/29 Checking commit f52856a99bc9 (block: Move sysemu QMP commands to QAPI 
block module)
12/29 Checking commit 40c88aa15edf (qemu-storage-daemon: Add --blockdev option)
13/29 Checking commit b3767de968be (qapi: Flatten object-add)
14/29 Checking commit 2a5424175819 (qemu-storage-daemon: Add --object option)
WARNING: Block comments use a leading /* on a separate line
#103: FILE: qemu-storage-daemon.c:155:
+                /* FIXME The keyval parser rejects 'help' arguments, so we must

WARNING: Block comments use a trailing */ on a separate line
#104: FILE: qemu-storage-daemon.c:156:
+                 * unconditionall try QemuOpts first. */

total: 0 errors, 2 warnings, 98 lines checked

Patch 14/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/29 Checking commit c3e93ca278e4 (qemu-storage-daemon: Add --nbd-server 
option)
16/29 Checking commit 95f79fa744ce (blockdev-nbd: Boxed argument type for 
nbd-server-add)
17/29 Checking commit 0f2bb9d607ae (qemu-storage-daemon: Add --export option)
18/29 Checking commit 2a264c475078 (qemu-storage-daemon: Add main loop)
ERROR: do not initialise statics to 0 or NULL
#46: FILE: qemu-storage-daemon.c:56:
+static volatile bool exit_requested = false;

ERROR: Use of volatile is usually wrong, please add a comment
#46: FILE: qemu-storage-daemon.c:56:
+static volatile bool exit_requested = false;

total: 2 errors, 0 warnings, 40 lines checked

Patch 18/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

19/29 Checking commit a32e4ac9537a (qemu-storage-daemon: Add --chardev option)
ERROR: externs should be avoided in .c files
#66: FILE: qemu-storage-daemon.c:117:
+extern QemuOptsList qemu_chardev_opts;

total: 1 errors, 0 warnings, 67 lines checked

Patch 19/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/29 Checking commit 501279700888 (stubs: Update monitor stubs for 
qemu-storage-daemon)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/29 Checking commit 85141e527412 (qapi: Create 'pragma' module)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

total: 0 errors, 1 warnings, 63 lines checked

Patch 21/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/29 Checking commit f7fbb5311767 (monitor: Create QAPIfied monitor_init())
23/29 Checking commit 1a7c87440187 (qmp: Fail gracefully if chardev is already 
in use)
24/29 Checking commit 73480ad8a7e9 (hmp: Fail gracefully if chardev is already 
in use)
25/29 Checking commit caf92c214b2a (monitor: Add allow_hmp parameter to 
monitor_init())
26/29 Checking commit b316a0bef865 (qemu-storage-daemon: Add --monitor option)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#269: 
new file mode 100644

total: 0 errors, 1 warnings, 228 lines checked

Patch 26/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/29 Checking commit 2d8f428e905e (block/rbd: Add support for ceph namespaces)
28/29 Checking commit b4fc54d15f7a (iotests: Refactor blockdev-reopen test for 
iothreads)
29/29 Checking commit 32121e1b2fa3 (block: bdrv_reopen() with backing file in 
different AioContext)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden