[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 1/9] qemu-binfmt-conf.sh: enforce safe style consistency
From: |
Unai Martinez-Corral |
Subject: |
[PATCH v8 1/9] qemu-binfmt-conf.sh: enforce safe style consistency |
Date: |
Sat, 7 Mar 2020 18:38:03 +0000 |
Spaces are added before '; then', for consistency.
All the tests are prefixed with 'x', in order to avoid risky comparisons
(i.e. a user deliberately trying to provoke a syntax error).
Signed-off-by: Unai Martinez-Corral <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
---
scripts/qemu-binfmt-conf.sh | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
index 9f1580a91c..672ce716b6 100755
--- a/scripts/qemu-binfmt-conf.sh
+++ b/scripts/qemu-binfmt-conf.sh
@@ -223,12 +223,12 @@ qemu_check_access() {
qemu_check_bintfmt_misc() {
# load the binfmt_misc module
- if [ ! -d /proc/sys/fs/binfmt_misc ]; then
+ if [ ! -d /proc/sys/fs/binfmt_misc ] ; then
if ! /sbin/modprobe binfmt_misc ; then
exit 1
fi
fi
- if [ ! -f /proc/sys/fs/binfmt_misc/register ]; then
+ if [ ! -f /proc/sys/fs/binfmt_misc/register ] ; then
if ! mount binfmt_misc -t binfmt_misc /proc/sys/fs/binfmt_misc ; then
exit 1
fi
@@ -259,10 +259,10 @@ qemu_check_systemd() {
qemu_generate_register() {
flags=""
- if [ "$CREDENTIAL" = "yes" ] ; then
+ if [ "x$CREDENTIAL" = "xyes" ] ; then
flags="OC"
fi
- if [ "$PERSISTENT" = "yes" ] ; then
+ if [ "x$PERSISTENT" = "xyes" ] ; then
flags="${flags}F"
fi
@@ -300,18 +300,18 @@ qemu_set_binfmts() {
mask=$(eval echo \$${cpu}_mask)
family=$(eval echo \$${cpu}_family)
- if [ "$magic" = "" ] || [ "$mask" = "" ] || [ "$family" = "" ] ; then
+ if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ] ;
then
echo "INTERNAL ERROR: unknown cpu $cpu" 1>&2
continue
fi
qemu="$QEMU_PATH/qemu-$cpu"
- if [ "$cpu" = "i486" ] ; then
+ if [ "x$cpu" = "xi486" ] ; then
qemu="$QEMU_PATH/qemu-i386"
fi
qemu="$qemu$QEMU_SUFFIX"
- if [ "$host_family" != "$family" ] ; then
+ if [ "x$host_family" != "x$family" ] ; then
$BINFMT_SET
fi
done
--
2.25.1
- [PATCH v8 0/9] qemu-binfmt-conf.sh, unai . martinezcorral, 2020/03/07
- [PATCH v8 1/9] qemu-binfmt-conf.sh: enforce safe style consistency,
Unai Martinez-Corral <=
- [PATCH v8 2/9] qemu-binfmt-conf.sh: make opts -p and -c boolean, Unai Martinez-Corral, 2020/03/07
- [PATCH v8 3/9] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT, Unai Martinez-Corral, 2020/03/07
- [PATCH v8 4/9] qemu-binfmt-conf.sh: use the same presentation format as for qemu-*, Unai Martinez-Corral, 2020/03/07
- [PATCH v8 5/9] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options, Unai Martinez-Corral, 2020/03/07
- [PATCH v8 6/9] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX, Unai Martinez-Corral, 2020/03/07
- [PATCH v8 7/9] qemu-binfmt-conf.sh: generalize <CPU> to positional [TARGETS], Unai Martinez-Corral, 2020/03/07
- [PATCH v8 8/9] qemu-binfmt-conf.sh: add option --clear, Unai Martinez-Corral, 2020/03/07
- [PATCH v8 9/9] qemu-binfmt-conf.sh: add --test, Unai Martinez-Corral, 2020/03/07
- Re: [PATCH v8 0/9] qemu-binfmt-conf.sh, no-reply, 2020/03/07
- Re: [PATCH v8 0/9] qemu-binfmt-conf.sh, no-reply, 2020/03/07