[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 0/9] qemu-binfmt-conf.sh
From: |
no-reply |
Subject: |
Re: [PATCH v8 0/9] qemu-binfmt-conf.sh |
Date: |
Sat, 7 Mar 2020 11:12:38 -0800 (PST) |
Patchew URL: https://patchew.org/QEMU/20200307170251.GA7@dd5f6ec33fb0/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v8 0/9] qemu-binfmt-conf.sh
Message-id: 20200307170251.GA7@dd5f6ec33fb0
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7df5f33 qemu-binfmt-conf.sh: add --test
a58e556 qemu-binfmt-conf.sh: add option --clear
42db124 qemu-binfmt-conf.sh: generalize <CPU> to positional [TARGETS]
e5ea0d0 qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX
633c743 qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options
b68ad24 qemu-binfmt-conf.sh: use the same presentation format as for qemu-*
38b00f7 qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT
cc882cd qemu-binfmt-conf.sh: make opts -p and -c boolean
183e4d5 qemu-binfmt-conf.sh: enforce safe style consistency
=== OUTPUT BEGIN ===
1/9 Checking commit 183e4d5f9c6f (qemu-binfmt-conf.sh: enforce safe style
consistency)
WARNING: line over 80 characters
#53: FILE: scripts/qemu-binfmt-conf.sh:303:
+ if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ] ;
then
total: 0 errors, 1 warnings, 47 lines checked
Patch 1/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/9 Checking commit cc882cde65df (qemu-binfmt-conf.sh: make opts -p and -c
boolean)
ERROR: line over 90 characters
#51: FILE: scripts/qemu-binfmt-conf.sh:331:
+options=$(getopt -o ds:Q:S:e:hcp -l
debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent
-- "$@")
total: 1 errors, 0 warnings, 43 lines checked
Patch 2/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/9 Checking commit 38b00f7dd75c (qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and
QEMU_PERSISTENT)
4/9 Checking commit b68ad248d5e0 (qemu-binfmt-conf.sh: use the same
presentation format as for qemu-*)
WARNING: line over 80 characters
#51: FILE: scripts/qemu-binfmt-conf.sh:183:
+-F|--qemu-suffix SUFFIX add a suffix to the default interpreter
name
ERROR: line over 90 characters
#52: FILE: scripts/qemu-binfmt-conf.sh:184:
+-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it
in memory; all future
ERROR: line over 90 characters
#54: FILE: scripts/qemu-binfmt-conf.sh:186:
+-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are
calculated according
ERROR: line over 90 characters
#59: FILE: scripts/qemu-binfmt-conf.sh:191:
+ systemd-binfmt.service for the given
CPU; if CPU is "ALL",
ERROR: line over 90 characters
#61: FILE: scripts/qemu-binfmt-conf.sh:193:
+-d|--debian don't write into /proc, generate
update-binfmts templates
ERROR: line over 90 characters
#86: FILE: scripts/qemu-binfmt-conf.sh:210:
+The environment variable HOST_ARCH allows to override 'uname' to generate
configuration files for a
total: 5 errors, 1 warnings, 79 lines checked
Patch 4/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/9 Checking commit 633c7439b752 (qemu-binfmt-conf.sh: remove 'qemu' prefix
from cli options)
WARNING: line over 80 characters
#36: FILE: scripts/qemu-binfmt-conf.sh:184:
+-F|--suffix SUFFIX add a suffix to the default interpreter
name
ERROR: line over 90 characters
#45: FILE: scripts/qemu-binfmt-conf.sh:337:
+options=$(getopt -o ds:Q:S:e:hcp -l
debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@")
total: 1 errors, 1 warnings, 38 lines checked
Patch 5/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/9 Checking commit e5ea0d0db84d (qemu-binfmt-conf.sh: honour QEMU_PATH and/or
QEMU_SUFFIX)
WARNING: line over 80 characters
#23: FILE: scripts/qemu-binfmt-conf.sh:184:
+-F|--suffix SUFFIX QEMU_SUFFIX add a suffix to the default interpreter
name
total: 0 errors, 1 warnings, 30 lines checked
Patch 6/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/9 Checking commit 42db124d284a (qemu-binfmt-conf.sh: generalize <CPU> to
positional [TARGETS])
ERROR: line over 90 characters
#78: FILE: scripts/qemu-binfmt-conf.sh:203:
+TARGETS QEMU_TARGETS A single arch name or a list of them
(see all names below);
WARNING: line over 80 characters
#91: FILE: scripts/qemu-binfmt-conf.sh:215:
+-s|--systemd don't write into /proc, generate file(s)
for
ERROR: line over 90 characters
#105: FILE: scripts/qemu-binfmt-conf.sh:234:
+The environment variable HOST_ARCH allows to override 'uname' to generate
configuration files for
ERROR: line over 90 characters
#147: FILE: scripts/qemu-binfmt-conf.sh:363:
+options=$(getopt -o dsQ:S:e:hcp -l
debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@")
total: 3 errors, 1 warnings, 141 lines checked
Patch 7/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/9 Checking commit a58e5567f2be (qemu-binfmt-conf.sh: add option --clear)
WARNING: line over 80 characters
#34: FILE: scripts/qemu-binfmt-conf.sh:204:
+ if empty, configure/clear all known
targets;
ERROR: line over 90 characters
#42: FILE: scripts/qemu-binfmt-conf.sh:213:
+-r|--clear QEMU_CLEAR (yes) remove registered interpreters for
target TARGETS;
ERROR: line over 90 characters
#85: FILE: scripts/qemu-binfmt-conf.sh:381:
+options=$(getopt -o rdsQ:S:e:hcp -l
clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent --
"$@")
total: 2 errors, 1 warnings, 85 lines checked
Patch 8/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/9 Checking commit 7df5f332f7ba (qemu-binfmt-conf.sh: add --test)
WARNING: line over 80 characters
#21: FILE: scripts/qemu-binfmt-conf.sh:204:
+ if empty, configure/clear all known
targets.
ERROR: line over 90 characters
#29: FILE: scripts/qemu-binfmt-conf.sh:214:
+-t|--test QEMU_TEST (yes) test the setup with the provided
arguments, but do not
ERROR: line over 90 characters
#59: FILE: scripts/qemu-binfmt-conf.sh:381:
+options=$(getopt -o trdsQ:S:e:hcp -l
test,clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent
-- "$@")
total: 2 errors, 1 warnings, 61 lines checked
Patch 9/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200307170251.GA7@dd5f6ec33fb0/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [PATCH v8 0/9] qemu-binfmt-conf.sh, unai . martinezcorral, 2020/03/07
- [PATCH v8 1/9] qemu-binfmt-conf.sh: enforce safe style consistency, Unai Martinez-Corral, 2020/03/07
- [PATCH v8 2/9] qemu-binfmt-conf.sh: make opts -p and -c boolean, Unai Martinez-Corral, 2020/03/07
- [PATCH v8 3/9] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT, Unai Martinez-Corral, 2020/03/07
- [PATCH v8 4/9] qemu-binfmt-conf.sh: use the same presentation format as for qemu-*, Unai Martinez-Corral, 2020/03/07
- [PATCH v8 5/9] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options, Unai Martinez-Corral, 2020/03/07
- [PATCH v8 6/9] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX, Unai Martinez-Corral, 2020/03/07
- [PATCH v8 7/9] qemu-binfmt-conf.sh: generalize <CPU> to positional [TARGETS], Unai Martinez-Corral, 2020/03/07
- [PATCH v8 8/9] qemu-binfmt-conf.sh: add option --clear, Unai Martinez-Corral, 2020/03/07
- [PATCH v8 9/9] qemu-binfmt-conf.sh: add --test, Unai Martinez-Corral, 2020/03/07
- Re: [PATCH v8 0/9] qemu-binfmt-conf.sh,
no-reply <=
- Re: [PATCH v8 0/9] qemu-binfmt-conf.sh, no-reply, 2020/03/07