[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 05/16] hw/i386: Remove unnecessary initialization in x86_c
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v5 05/16] hw/i386: Remove unnecessary initialization in x86_cpu_new |
Date: |
Mon, 9 Mar 2020 15:18:52 +0100 |
On Tue, 03 Mar 2020 13:57:24 -0600
Babu Moger <address@hidden> wrote:
> The function pc_cpu_pre_plug takes care of initialization of CPUX86State.
> So, remove the initialization here.
>
> Suggested-by: Igor Mammedov <address@hidden>
> Signed-off-by: Babu Moger <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> hw/i386/x86.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/hw/i386/x86.c b/hw/i386/x86.c
> index 03b8962c98..79badcc4ec 100644
> --- a/hw/i386/x86.c
> +++ b/hw/i386/x86.c
> @@ -103,13 +103,9 @@ void x86_cpu_new(X86MachineState *x86ms, int64_t
> apic_id, Error **errp)
> {
> Object *cpu = NULL;
> Error *local_err = NULL;
> - CPUX86State *env = NULL;
>
> cpu = object_new(MACHINE(x86ms)->cpu_type);
>
> - env = &X86_CPU(cpu)->env;
> - env->nr_dies = x86ms->smp_dies;
> -
> object_property_set_uint(cpu, apic_id, "apic-id", &local_err);
> object_property_set_bool(cpu, true, "realized", &local_err);
>
>
- [PATCH v5 00/16] APIC ID fixes for AMD EPYC CPU model, Babu Moger, 2020/03/03
- [PATCH v5 01/16] hw/i386: Rename X86CPUTopoInfo structure to X86CPUTopoIDs, Babu Moger, 2020/03/03
- [PATCH v5 03/16] hw/i386: Consolidate topology functions, Babu Moger, 2020/03/03
- [PATCH v5 05/16] hw/i386: Remove unnecessary initialization in x86_cpu_new, Babu Moger, 2020/03/03
- Re: [PATCH v5 05/16] hw/i386: Remove unnecessary initialization in x86_cpu_new,
Igor Mammedov <=
- [PATCH v5 02/16] hw/i386: Introduce X86CPUTopoInfo to contain topology info, Babu Moger, 2020/03/03
- [PATCH v5 04/16] machine: Add SMP Sockets in CpuTopology, Babu Moger, 2020/03/03
- [PATCH v5 06/16] hw/i386: Update structures to save the number of nodes per package, Babu Moger, 2020/03/03
- [PATCH v5 08/16] hw/386: Add EPYC mode topology decoding functions, Babu Moger, 2020/03/03
- [PATCH v5 07/16] hw/i386: Rename apicid_from_topo_ids to x86_apicid_from_topo_ids, Babu Moger, 2020/03/03