Re: [PATCH v5 05/16] hw/i386: Remove unnecessary initialization in x86_cpu_new

[Igor Mammedov]

On Tue, 03 Mar 2020 13:57:24 -0600
Babu Moger <address@hidden> wrote:

> The function pc_cpu_pre_plug takes care of initialization of CPUX86State.
> So, remove the initialization here.
> 
> Suggested-by: Igor Mammedov <address@hidden>
> Signed-off-by: Babu Moger <address@hidden>

Reviewed-by: Igor Mammedov <address@hidden>

> ---
>  hw/i386/x86.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/hw/i386/x86.c b/hw/i386/x86.c
> index 03b8962c98..79badcc4ec 100644
> --- a/hw/i386/x86.c
> +++ b/hw/i386/x86.c
> @@ -103,13 +103,9 @@ void x86_cpu_new(X86MachineState *x86ms, int64_t 
> apic_id, Error **errp)
>  {
>      Object *cpu = NULL;
>      Error *local_err = NULL;
> -    CPUX86State *env = NULL;
>  
>      cpu = object_new(MACHINE(x86ms)->cpu_type);
>  
> -    env = &X86_CPU(cpu)->env;
> -    env->nr_dies = x86ms->smp_dies;
> -
>      object_property_set_uint(cpu, apic_id, "apic-id", &local_err);
>      object_property_set_bool(cpu, true, "realized", &local_err);
>  
>