[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC] cpus: avoid get stuck in pause_all_vcpus
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [RFC] cpus: avoid get stuck in pause_all_vcpus |
|
Date: |
Fri, 13 Mar 2020 08:09:55 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 13/03/20 02:43, Longpeng (Mike, Cloud Infrastructure Service Product
Dept.) wrote:
>> diff --git a/cpus.c b/cpus.c
>> index b4f8b84b61..1eb7533a91 100644
>> --- a/cpus.c
>> +++ b/cpus.c
>> @@ -1899,6 +1899,10 @@ void resume_all_vcpus(void)
>> {
>> CPUState *cpu;
>>
>> + if (!runstate_is_running()) {
>> + return;
>> + }
>> +
> Hi Paolo,
>
> The runstate of my above sketch is running, so maybe your patch can fix some
> other issues but not mine ?
You're right, do_vm_stop sets the runstate after pause_all_vcpus. We
can move that before and it should fix your case too.
Paolo