[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC] cpus: avoid get stuck in pause_all_vcpus
From: |
Longpeng (Mike, Cloud Infrastructure Service Product Dept.) |
Subject: |
Re: [RFC] cpus: avoid get stuck in pause_all_vcpus |
Date: |
Fri, 13 Mar 2020 16:36:35 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 2020/3/13 15:09, Paolo Bonzini wrote:
> On 13/03/20 02:43, Longpeng (Mike, Cloud Infrastructure Service Product
> Dept.) wrote:
>>> diff --git a/cpus.c b/cpus.c
>>> index b4f8b84b61..1eb7533a91 100644
>>> --- a/cpus.c
>>> +++ b/cpus.c
>>> @@ -1899,6 +1899,10 @@ void resume_all_vcpus(void)
>>> {
>>> CPUState *cpu;
>>>
>>> + if (!runstate_is_running()) {
>>> + return;
>>> + }
>>> +
>> Hi Paolo,
>>
>> The runstate of my above sketch is running, so maybe your patch can fix some
>> other issues but not mine ?
>
> You're right, do_vm_stop sets the runstate after pause_all_vcpus. We
> can move that before and it should fix your case too.
>
Uh, it seems to work. So can I send a patch based on your suggestion ? Or feel
free to do if you want to fix it by yourself.
> Paolo
>
>
---
Regards,
Longpeng(Mike)