[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/8] Misc hw/ide legacy clean up

From: BALATON Zoltan
Subject: Re: [PATCH 0/8] Misc hw/ide legacy clean up
Date: Mon, 16 Mar 2020 14:06:52 +0100 (CET)
User-agent: Alpine 2.22 (BSF 395 2020-01-19)

On Mon, 16 Mar 2020, Markus Armbruster wrote:
BALATON Zoltan <address@hidden> writes:
These are some clean ups to remove more legacy init functions and
lessen dependence on include/hw/ide.h with some simplifications in
board code. There should be no functional change.

PATCH 1 could quote precedence more clearly in the commit message, but
that's detail.

I don't like PATCH 4.

Sent alternative v2 version of patch 7 so you can drop patch 4 if you like, the rest of the series should apply unchanged. Note that there might be some places where MAX_IDE_BUS is defined but not used and current code probably has assumption about this being 2 elsewhere and would break with any other value so other than philosophical there should be no reason to keep this defined everywhere.

PATCH 1-3,5-8:
Reviewed-by: Markus Armbruster <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]