[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/8] Misc hw/ide legacy clean up

From: John Snow
Subject: Re: [PATCH 0/8] Misc hw/ide legacy clean up
Date: Tue, 17 Mar 2020 00:25:09 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 3/16/20 9:41 AM, BALATON Zoltan wrote:
> On Mon, 16 Mar 2020, BALATON Zoltan wrote:
>> On Mon, 16 Mar 2020, Markus Armbruster wrote:
>>> BALATON Zoltan <address@hidden> writes:
>>>> These are some clean ups to remove more legacy init functions and
>>>> lessen dependence on include/hw/ide.h with some simplifications in
>>>> board code. There should be no functional change.
>>> PATCH 1 could quote precedence more clearly in the commit message, but
>>> that's detail.
>>> I don't like PATCH 4.
>> Sent alternative v2 version of patch 7 so you can drop patch 4 if you
>> like,
> and patch 6 v2 also sent that is affected as well if you drop patch 4.
>> the rest of the series should apply unchanged. Note that there might
>> be some places where MAX_IDE_BUS is defined but not used and current
>> code probably has assumption about this being 2 elsewhere and would
>> break with any other value so other than philosophical there should be
>> no reason to keep this defined everywhere.
>>> PATCH 1-3,5-8:
>>> Reviewed-by: Markus Armbruster <address@hidden>
>> Thanks.
>> Regards,
>> BALATON Zoltan

Can you do me a favor and send a proper v2 of the whole series, with
review tags applied?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]