[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/34] qapi: Belatedly update doc comment for @wait deprec
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [PATCH v3 02/34] qapi: Belatedly update doc comment for @wait deprecation |
|
Date: |
Mon, 16 Mar 2020 15:51:03 +0100 |
Hi
On Sun, Mar 15, 2020 at 3:48 PM Markus Armbruster <address@hidden> wrote:
>
> Commit a9b305ba29 "socket: allow wait=false for client socket"
> deprecated use of @wait for client socket chardevs, but neglected to
> update char.json's doc comment. Make up for that.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> qapi/char.json | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qapi/char.json b/qapi/char.json
> index 6907b2bfdb..daceb20f84 100644
> --- a/qapi/char.json
> +++ b/qapi/char.json
> @@ -258,6 +258,7 @@
> # @server: create server socket (default: true)
> # @wait: wait for incoming connection on server
> # sockets (default: false).
> +# Silently ignored with server: false. This use is deprecated.
> # @nodelay: set TCP_NODELAY socket option (default: false)
> # @telnet: enable telnet protocol on server
> # sockets (default: false)
> --
> 2.21.1
>
>
--
Marc-André Lureau
- [PATCH v3 10/34] tests/test-qmp-event: Check event is actually emitted, (continued)
- [PATCH v3 10/34] tests/test-qmp-event: Check event is actually emitted, Markus Armbruster, 2020/03/15
- [PATCH v3 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers, Markus Armbruster, 2020/03/15
- [PATCH v3 23/34] qapi: Simplify how qmp_dispatch() gets the request ID, Markus Armbruster, 2020/03/15
- [PATCH v3 02/34] qapi: Belatedly update doc comment for @wait deprecation, Markus Armbruster, 2020/03/15
- [PATCH v3 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an explanation, Markus Armbruster, 2020/03/15
- [PATCH v3 32/34] qapi: Implement deprecated-input=reject for QMP commands, Markus Armbruster, 2020/03/15
- [PATCH v3 16/34] qapi/schema: Change _make_features() to a take feature list, Markus Armbruster, 2020/03/15
- [PATCH v3 21/34] qapi: Inline do_qmp_dispatch() into qmp_dispatch(), Markus Armbruster, 2020/03/15
- [PATCH v3 08/34] tests/test-qmp-event: Simplify test data setup, Markus Armbruster, 2020/03/15