[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 10/34] tests/test-qmp-event: Check event is actually emitt
From: |
Marc-André Lureau |
Subject: |
Re: [PATCH v3 10/34] tests/test-qmp-event: Check event is actually emitted |
Date: |
Mon, 16 Mar 2020 16:14:14 +0100 |
On Sun, Mar 15, 2020 at 3:55 PM Markus Armbruster <address@hidden> wrote:
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> tests/test-qmp-event.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tests/test-qmp-event.c b/tests/test-qmp-event.c
> index d64066139c..7dd0053190 100644
> --- a/tests/test-qmp-event.c
> +++ b/tests/test-qmp-event.c
> @@ -26,6 +26,7 @@
>
> typedef struct TestEventData {
> QDict *expect;
> + bool emitted;
> } TestEventData;
>
> TestEventData *test_event_data;
> @@ -52,7 +53,7 @@ void test_qapi_event_emit(test_QAPIEvent event, QDict *d)
> qdict_del(d, "timestamp");
>
> g_assert(qobject_is_equal(QOBJECT(d), QOBJECT(test_event_data->expect)));
> -
> + test_event_data->emitted = true;
> }
>
> static void event_prepare(TestEventData *data,
> @@ -87,6 +88,7 @@ static void test_event_a(TestEventData *data,
> {
> data->expect = qdict_from_jsonf_nofail("{ 'event': 'EVENT_A' }");
> qapi_event_send_event_a();
> + g_assert(data->emitted);
> qobject_unref(data->expect);
> }
>
> @@ -95,6 +97,7 @@ static void test_event_b(TestEventData *data,
> {
> data->expect = qdict_from_jsonf_nofail("{ 'event': 'EVENT_B' }");
> qapi_event_send_event_b();
> + g_assert(data->emitted);
> qobject_unref(data->expect);
> }
>
> @@ -107,6 +110,7 @@ static void test_event_c(TestEventData *data,
> "{ 'event': 'EVENT_C', 'data': {"
> " 'a': 1, 'b': { 'integer': 2, 'string': 'test1' }, 'c': 'test2' }
> }");
> qapi_event_send_event_c(true, 1, true, &b, "test2");
> + g_assert(data->emitted);
> qobject_unref(data->expect);
> }
>
> @@ -132,6 +136,7 @@ static void test_event_d(TestEventData *data,
> " 'string': 'test2', 'enum2': 'value2' },"
> " 'b': 'test3', 'enum3': 'value3' } }");
> qapi_event_send_event_d(&a, "test3", false, NULL, true, ENUM_ONE_VALUE3);
> + g_assert(data->emitted);
> qobject_unref(data->expect);
> }
>
> --
> 2.21.1
>
>
--
Marc-André Lureau
- [PATCH v3 00/34] Configurable policy for handling deprecated interfaces, Markus Armbruster, 2020/03/15
- [PATCH v3 09/34] tests/test-qmp-event: Use qobject_is_equal(), Markus Armbruster, 2020/03/15
- [PATCH v3 03/34] docs/devel/qapi-code-gen: Clarify allow-oob introspection, Markus Armbruster, 2020/03/15
- [PATCH v3 06/34] tests/test-qmp-cmds: Check responses more thoroughly, Markus Armbruster, 2020/03/15
- [PATCH v3 10/34] tests/test-qmp-event: Check event is actually emitted, Markus Armbruster, 2020/03/15
- Re: [PATCH v3 10/34] tests/test-qmp-event: Check event is actually emitted,
Marc-André Lureau <=
- [PATCH v3 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers, Markus Armbruster, 2020/03/15
- [PATCH v3 23/34] qapi: Simplify how qmp_dispatch() gets the request ID, Markus Armbruster, 2020/03/15
- [PATCH v3 02/34] qapi: Belatedly update doc comment for @wait deprecation, Markus Armbruster, 2020/03/15