qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro


From: Juan Quintela
Subject: Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro
Date: Wed, 18 Mar 2020 14:02:37 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Yuri Benditovich <address@hidden> wrote:
> Similar to VMSTATE_VARRAY_UINT32_ALLOC, but the size is
> 16-bit field.
>
> Signed-off-by: Yuri Benditovich <address@hidden>

Reviewed-by: Juan Quintela <address@hidden>

Same caveat about attribution to MST.

Once told tha, I don't understand why you are using a unit16_t.
You define indirections_len as:

+    uint16_t indirections_len;

But its maximum value right now is:

+#define VIRTIO_NET_RSS_MAX_TABLE_LEN    128

So, are we planning to increase that value in the next future, or we
just want to give enough space?

Later, Juan.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]