[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro |
Date: |
Wed, 18 Mar 2020 11:19:40 -0400 |
On Wed, Mar 18, 2020 at 02:02:37PM +0100, Juan Quintela wrote:
> Yuri Benditovich <address@hidden> wrote:
> > Similar to VMSTATE_VARRAY_UINT32_ALLOC, but the size is
> > 16-bit field.
> >
> > Signed-off-by: Yuri Benditovich <address@hidden>
>
> Reviewed-by: Juan Quintela <address@hidden>
>
> Same caveat about attribution to MST.
>
> Once told tha, I don't understand why you are using a unit16_t.
> You define indirections_len as:
>
> + uint16_t indirections_len;
>
> But its maximum value right now is:
>
> +#define VIRTIO_NET_RSS_MAX_TABLE_LEN 128
>
> So, are we planning to increase that value in the next future, or we
> just want to give enough space?
>
> Later, Juan.
The max size according to spec is u16. Using that limits
the size and makes it forward compatible.
- [PATCH v5 1/7] virtio-net: introduce RSS and hash report features, (continued)
- [PATCH v5 1/7] virtio-net: introduce RSS and hash report features, Yuri Benditovich, 2020/03/18
- [PATCH v5 2/7] virtio-net: implement RSS configuration command, Yuri Benditovich, 2020/03/18
- [PATCH v5 4/7] tap: allow extended virtio header with hash info, Yuri Benditovich, 2020/03/18
- [PATCH v5 3/7] virtio-net: implement RX RSS processing, Yuri Benditovich, 2020/03/18
- [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro, Yuri Benditovich, 2020/03/18
- Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro, Dr. David Alan Gilbert, 2020/03/18
- Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro, Juan Quintela, 2020/03/18
- Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro,
Michael S. Tsirkin <=
- [PATCH v5 5/7] virtio-net: reference implementation of hash report, Yuri Benditovich, 2020/03/18
- [PATCH v5 7/7] virtio-net: add migration support for RSS and hash report, Yuri Benditovich, 2020/03/18
Re: [PATCH v5 0/7] reference implementation of RSS and hash report, Michael S. Tsirkin, 2020/03/18
Re: [PATCH v5 0/7] reference implementation of RSS and hash report, no-reply, 2020/03/18