[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/9] hmp-cmd: fix a missing_break warning
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 1/9] hmp-cmd: fix a missing_break warning |
Date: |
Wed, 25 Mar 2020 13:16:24 +0000 |
From: Pan Nengyuan <address@hidden>
This fix coverity issues 94417686:
1260 break;
CID 94417686: (MISSING_BREAK)
1261. unterminated_case: The case for value
"MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a 'break'
statement.
1261 case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD:
1262 p->has_throttle_trigger_threshold = true;
1263 visit_type_int(v, param, &p->throttle_trigger_threshold, &err);
1264 case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL:
Fixes: dc14a470763c96fd9d360e1028ce38e8c3613a77
Fixes: Coverity (CID 1421950)
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Pan Nengyuan <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Keqian Zhu <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
monitor/hmp-cmds.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 58724031ea..c882c9f3cc 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1261,6 +1261,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict
*qdict)
case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD:
p->has_throttle_trigger_threshold = true;
visit_type_int(v, param, &p->throttle_trigger_threshold, &err);
+ break;
case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL:
p->has_cpu_throttle_initial = true;
visit_type_int(v, param, &p->cpu_throttle_initial, &err);
--
2.25.1
- [PULL 0/9] migration queue, Dr. David Alan Gilbert (git), 2020/03/25
- [PULL 2/9] xbzrle: update xbzrle doc, Dr. David Alan Gilbert (git), 2020/03/25
- [PULL 1/9] hmp-cmd: fix a missing_break warning,
Dr. David Alan Gilbert (git) <=
- [PULL 3/9] tests/migration: Reduce autoconverge initial bandwidth, Dr. David Alan Gilbert (git), 2020/03/25
- [PULL 4/9] hmp/vnc: Fix info vnc list leak, Dr. David Alan Gilbert (git), 2020/03/25
- [PULL 5/9] tools/virtiofsd/passthrough_ll: Fix double close(), Dr. David Alan Gilbert (git), 2020/03/25
- [PULL 6/9] vl.c: fix migration failure for 3.1 and older machine types, Dr. David Alan Gilbert (git), 2020/03/25
- [PULL 7/9] migration/colo: fix use after free of local_err, Dr. David Alan Gilbert (git), 2020/03/25
- [PULL 9/9] migration: use "" instead of (null) for tls-authz, Dr. David Alan Gilbert (git), 2020/03/25
- [PULL 8/9] migration/ram: fix use after free of local_err, Dr. David Alan Gilbert (git), 2020/03/25
- Re: [PULL 0/9] migration queue, Peter Maydell, 2020/03/26