[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PULL 7/9] migration/colo: fix use after free of local_err

From: Dr. David Alan Gilbert (git)
Subject: [PULL 7/9] migration/colo: fix use after free of local_err
Date: Wed, 25 Mar 2020 13:16:30 +0000

From: Vladimir Sementsov-Ogievskiy <address@hidden>

local_err is used again in secondary_vm_do_failover() after
replication_stop_all(), so we must zero it. Otherwise try to set
non-NULL local_err will crash.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
 migration/colo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/migration/colo.c b/migration/colo.c
index 44942c4e23..a54ac84f41 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -93,6 +93,7 @@ static void secondary_vm_do_failover(void)
     replication_stop_all(true, &local_err);
     if (local_err) {
+        local_err = NULL;
     /* Notify all filters of all NIC to do checkpoint */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]