[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] Fix the generic image creation code
From: |
Max Reitz |
Subject: |
Re: [PATCH 0/2] Fix the generic image creation code |
Date: |
Thu, 26 Mar 2020 13:23:31 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 26.03.20 02:12, Maxim Levitsky wrote:
> The recent patches from Max Reitz allowed some block drivers to not
> provide the .bdrv_co_create_opts and still allow qemu-img to
> create/format images as long as the image is already existing
> (that is the case with various block storage drivers like nbd/iscsi/nvme, etc)
>
> However it was found out that some places in the code depend on the
> .bdrv_co_create_opts/.create_opts to be != NULL to decide if to allow
> image creation.
>
> To avoid adding failback code to all these places, just make generic failback
> code be used by the drivers that need it, so that for outside user, there
> is no diffirence if failback was used or not.
>
> Best regards,
> Maxim Levitsky
>
> Maxim Levitsky (2):
> block: pass BlockDriver reference to the .bdrv_co_create
> block: trickle down the fallback image creation function use to the
> block drivers
Thanks, fixed the function parameter alignment, moved the declarations
from block.h into block_int.h, and applied the series to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 1/2] block: pass BlockDriver reference to the .bdrv_co_create, (continued)
[PATCH 2/2] block: trickle down the fallback image creation function use to the block drivers, Maxim Levitsky, 2020/03/25
Re: [PATCH 2/2] block: trickle down the fallback image creation function use to the block drivers, Maxim Levitsky, 2020/03/26
Re: [PATCH 0/2] Fix the generic image creation code, Denis V. Lunev, 2020/03/26
Re: [PATCH 0/2] Fix the generic image creation code,
Max Reitz <=