[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] block: trickle down the fallback image creation function
From: |
Kevin Wolf |
Subject: |
Re: [PATCH 2/2] block: trickle down the fallback image creation function use to the block drivers |
Date: |
Thu, 26 Mar 2020 14:28:28 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 26.03.2020 um 14:20 hat Eric Blake geschrieben:
> > +++ b/block/file-posix.c
> > @@ -3513,6 +3513,8 @@ static BlockDriver bdrv_host_device = {
> > .bdrv_reopen_prepare = raw_reopen_prepare,
> > .bdrv_reopen_commit = raw_reopen_commit,
> > .bdrv_reopen_abort = raw_reopen_abort,
> > + .bdrv_co_create_opts = bdrv_co_create_opts_simple,
> > + .create_opts = &bdrv_create_opts_simple,
>
> I'd drop the leading & for consistency with the rest of this struct
> initializer.
This one isn't a function pointer, so I think the & is necessary.
Kevin
Re: [PATCH 0/2] Fix the generic image creation code, Denis V. Lunev, 2020/03/26
Re: [PATCH 0/2] Fix the generic image creation code, Max Reitz, 2020/03/26