Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

[Maciej S. Szmigiero]

Hi Jon,

The patches are available here:
https://github.com/maciejsszmigiero/qemu.git in "vmbus-patches" branch.

Please note that these patches don't have Roman's "Signed-off-by:" tags,
so I haven't applied mine, either.

If you are able to establish a proper SoB chain then please also add:
"Signed-off-by: Maciej S. Szmigiero <address@hidden>".

Thanks for the effort,
Maciej

On 03.04.2020 17:30, Jon Doron wrote:
>  Thank you Maciej it seems like your version is really ahead I'll do
> the required work and merge it so i can submit a v2 with the latest
> patchset from Roman
> 
> On Fri, Apr 3, 2020 at 6:06 PM Jon Doron <address@hidden> wrote:
>>
>> Thank you Maciej, I based it on top of what Denis (address@hidden) gave me
>> which was this:
>> https://ftp.openvz.org/virtuozzo/releases/openvz-7.0.12-288/source/SRPMS/q/qemu-kvm-vz-2.12.0-33.vz7.14.4.src.rpm
>>
>> Do you think you have a more recent version I dont mind diffing and
>> resubmitting a new version of the patchset?
>>
>> Thanks,
>> -- Jon.
>>
>> On Fri, Apr 3, 2020 at 5:56 PM Maciej S. Szmigiero
>> <address@hidden> wrote:
>>>
>>> Hi Jon,
>>>
>>> On 03.04.2020 16:23, Jon Doron wrote:
>>>> Guest OS uses ACPI to discover vmbus presence.  Add a corresponding
>>>> entry to DSDT in case vmbus has been enabled.
>>>>
>>>> Experimentally Windows guests were found to require this entry to
>>>> include two IRQ resources, so this patch adds two semi-arbitrarily
>>>> chosen ones (7 and 13).  This results, in particular, in parallel port
>>>> conflicting with vmbus.
>>>>
>>>> TODO: discover and use spare IRQs to avoid conflicts.
>>>>
>>>> Signed-off-by: Evgeny Yakovlev <address@hidden>
>>>> Signed-off-by: Roman Kagan <address@hidden>
>>>> Signed-off-by: Jon Doron <address@hidden>
>>>
>>> Nice work, thanks!
>>>
>>> However, it seems to be based on the code version that was posted in
>>> February 2018, and not the latest version in OpenVZ qemu repository
>>> dated October 2019:
>>> https://src.openvz.org/projects/UP/repos/qemu/commits?until=refs%2Fheads%2Fvmbus
>>>
>>> This newer version has slightly different API here and there.
>>> Any particular reason for selecting that older version for porting?
>>>
>>> I have actually rebased this latest version on the top of the current
>>> QEMU master, and it basically seems to work fine.
>>> However, I haven't done extensive tests whether there isn't a memory leak
>>> somewhere or so on.
>>>
>>> Maciej