[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 08/12] linux-user: factor out reading of /proc/self/maps
|
From: |
Alex Bennée |
|
Subject: |
Re: [PATCH v3 08/12] linux-user: factor out reading of /proc/self/maps |
|
Date: |
Mon, 06 Apr 2020 10:09:19 +0100 |
|
User-agent: |
mu4e 1.3.10; emacs 28.0.50 |
Richard Henderson <address@hidden> writes:
> On 4/3/20 12:11 PM, Alex Bennée wrote:
>> + e->is_read = fields[1][0] == 'r' ? true : false;
>> + e->is_write = fields[1][1] == 'w' ? true : false;
>> + e->is_exec = fields[1][2] == 'x' ? true : false;
>> + e->is_priv = fields[1][3] == 'p' ? true : false;
>
> Drop the redundant ? true : false. That is of course the result of the
> boolean
> operation.
doh! Fortunately the compiler was smart enough to see through my idiocy...
>
>> + errors += qemu_strtoi(fields[4], NULL, 10, &e->inode);
>
> The root of the typedef chain for ino_t is
>
> /usr/include/asm-generic/posix_types.h:typedef __kernel_ulong_t
> __kernel_ino_t;
>
> so I think you should just go ahead and use unsigned long here too. Or maybe
> even uint64_t, because 32-bit has ino64_t, and could in fact have a Large
> Number here.
Will fix.
>
>
> r~
--
Alex Bennée
- [PATCH v3 for 5.0-rc2 00/12] a selection of random fixes, Alex Bennée, 2020/04/03
- [PATCH v3 01/12] elf-ops: bail out if we have no function symbols, Alex Bennée, 2020/04/03
- [PATCH v3 03/12] tests/tcg: remove extraneous pasting macros, Alex Bennée, 2020/04/03
- [PATCH v3 02/12] linux-user: protect fcntl64 with an #ifdef, Alex Bennée, 2020/04/03
- [PATCH v3 06/12] gdbstub: fix compiler complaining, Alex Bennée, 2020/04/03
- [PATCH v3 07/12] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Alex Bennée, 2020/04/03
- [PATCH v3 08/12] linux-user: factor out reading of /proc/self/maps, Alex Bennée, 2020/04/03
- [PATCH v3 04/12] linux-user: more debug for init_guest_space, Alex Bennée, 2020/04/03
- [PATCH v3 05/12] target/xtensa: add FIXME for translation memory leak, Alex Bennée, 2020/04/03
- [PATCH v3 10/12] target/arm: don't expose "ieee_half" via gdbstub, Alex Bennée, 2020/04/03
- [PATCH v3 09/12] linux-user: clean-up padding on /proc/self/maps, Alex Bennée, 2020/04/03
- [PATCH v3 12/12] configure: Add -Werror to PIE probe, Alex Bennée, 2020/04/03
- [PATCH v3 11/12] hw/core: properly terminate loading .hex on EOF record, Alex Bennée, 2020/04/03