[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 0/4] async: fix hangs on weakly-ordered architectures
From: |
Stefan Hajnoczi |
Subject: |
Re: [RFC PATCH 0/4] async: fix hangs on weakly-ordered architectures |
Date: |
Tue, 7 Apr 2020 10:10:16 +0100 |
On Mon, Apr 06, 2020 at 03:13:16PM -0400, Paolo Bonzini wrote:
> Patch 4 fixes qemu-img and qemu-io hangs on weakly-ordered architectures.
> Patch 1-3 are related docs fixes and improvements.
>
> This is RFC because it relies on the iothread being locked during aio_poll
> on the main AioContext. If I add assertions for this however I see a
> failure for test 267, so I am posting it as a preview before I debug that.
> The doc patches can also go in independently of course.
>
> Paolo
>
> Paolo Bonzini (4):
> atomics: convert to reStructuredText
> atomics: update documentation for C11
> rcu: do not mention atomic_mb_read/set in documentation
> async: use explicit memory barriers
>
> docs/devel/atomics.rst | 385 +++++++++++++++++++++++++++++++++++++++
> docs/devel/atomics.txt | 403 -----------------------------------------
> docs/devel/index.rst | 1 +
> docs/devel/rcu.txt | 4 +-
> util/aio-posix.c | 9 +-
> util/aio-win32.c | 8 +-
> util/async.c | 12 +-
> 7 files changed, 413 insertions(+), 409 deletions(-)
> create mode 100644 docs/devel/atomics.rst
> delete mode 100644 docs/devel/atomics.txt
I have left comments requesting clarifications, but the code change
looks fine:
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [PATCH 4/4] async: use explicit memory barriers and relaxed accesses, (continued)
- [PATCH 4/4] async: use explicit memory barriers and relaxed accesses, Paolo Bonzini, 2020/04/06
- [PATCH 2/4] atomics: update documentation for C11, Paolo Bonzini, 2020/04/06
- [PATCH 1/4] atomics: convert to reStructuredText, Paolo Bonzini, 2020/04/06
- Re: [RFC PATCH 0/4] async: fix hangs on weakly-ordered architectures,
Stefan Hajnoczi <=
- [RFC PATCH 0/4] async: fix hangs on weakly-ordered architectures, Paolo Bonzini, 2020/04/07
- [PATCH 1/5] atomics: convert to reStructuredText, Paolo Bonzini, 2020/04/07
- [PATCH 5/5] async: use explicit memory barriers, Paolo Bonzini, 2020/04/07