[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.0 v2 3/3] block: Fix blk->in_flight during blk_wait_whi
|
From: |
Max Reitz |
|
Subject: |
Re: [PATCH for-5.0 v2 3/3] block: Fix blk->in_flight during blk_wait_while_drained() |
|
Date: |
Tue, 7 Apr 2020 12:12:11 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 06.04.20 19:14, Kevin Wolf wrote:
> Waiting in blk_wait_while_drained() while blk->in_flight is increased
> for the current request is wrong because it will cause the drain
> operation to deadlock.
>
> This patch makes sure that blk_wait_while_drained() is called with
> blk->in_flight increased exactly once for the current request, and that
> it temporarily decreases the counter while it waits.
>
> Fixes: cf3129323f900ef5ddbccbe86e4fa801e88c566e
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/block-backend.c | 17 +++++------------
> 1 file changed, 5 insertions(+), 12 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH for-5.0 v2 2/3] block: Increase BB.in_flight for coroutine interfaces, (continued)
Re: [PATCH for-5.0 v2 2/3] block: Increase BB.in_flight for coroutine interfaces, Max Reitz, 2020/04/07
[PATCH for-5.0 v2 3/3] block: Fix blk->in_flight during blk_wait_while_drained(), Kevin Wolf, 2020/04/06
Re: [PATCH for-5.0 v2 3/3] block: Fix blk->in_flight during blk_wait_while_drained(),
Max Reitz <=