Re: [PATCH v7 10/48] nvme: remove redundant cmbloc/cmbsz members

[Philippe Mathieu-Daudé]

On 4/15/20 9:19 AM, Klaus Birkelund Jensen wrote:
> On Apr 15 09:10, Philippe Mathieu-Daudé wrote:
> > "hw/block/nvme.h" should not pull in "block/nvme.h", both should include a
> > common "hw/block/nvme_spec.h" (or better named). Not related to this patch
> > although.
>
> Hmm. It does pull in the "include/block/nvme.h" which is basically the
> "nvme_spec.h" you are talking about. That file holds all spec related
> structs that are shared between the VFIO based nvme driver
> (block/nvme.c) and the emulated device (hw/block/nvme.c).
>
> Isn't that what is intended?

You are correct, "include/block/nvme.h" contains the spec definitions. I 
was expecting to see (QEMU) block-related structure in it, but they aren't.