[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 6/8] cpus: Introduce qemu_mutex_unlock_iothread_prepare()
From: |
Peter Xu |
Subject: |
[PATCH 6/8] cpus: Introduce qemu_mutex_unlock_iothread_prepare() |
Date: |
Tue, 21 Apr 2020 12:21:06 -0400 |
The prepare function before unlocking BQL. There're only three places that can
release the BQL: unlock(), cond_wait() or cond_timedwait().
Signed-off-by: Peter Xu <address@hidden>
---
cpus.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/cpus.c b/cpus.c
index 5cbc3f30de..48aa295fea 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1832,20 +1832,27 @@ void qemu_mutex_lock_iothread_impl(const char *file,
int line)
iothread_locked = true;
}
+static void qemu_mutex_unlock_iothread_prepare(void)
+{
+}
+
void qemu_mutex_unlock_iothread(void)
{
g_assert(qemu_mutex_iothread_locked());
iothread_locked = false;
+ qemu_mutex_unlock_iothread_prepare();
qemu_mutex_unlock(&qemu_global_mutex);
}
void qemu_cond_wait_iothread(QemuCond *cond)
{
+ qemu_mutex_unlock_iothread_prepare();
qemu_cond_wait(cond, &qemu_global_mutex);
}
void qemu_cond_timedwait_iothread(QemuCond *cond, int ms)
{
+ qemu_mutex_unlock_iothread_prepare();
qemu_cond_timedwait(cond, &qemu_global_mutex, ms);
}
--
2.24.1
- [PATCH 0/8] memory: Sanity checks memory transaction when releasing BQL, Peter Xu, 2020/04/21
- [PATCH 1/8] memory: Introduce memory_region_transaction_{push|pop}(), Peter Xu, 2020/04/21
- [PATCH 2/8] memory: Don't do topology update in memory finalize(), Peter Xu, 2020/04/21
- [PATCH 4/8] cpus: Introduce qemu_cond_timedwait_iothread(), Peter Xu, 2020/04/21
- [PATCH 3/8] cpus: Use qemu_cond_wait_iothread() where proper, Peter Xu, 2020/04/21
- [PATCH 5/8] cpus: Remove the mutex parameter from do_run_on_cpu(), Peter Xu, 2020/04/21
- [PATCH 6/8] cpus: Introduce qemu_mutex_unlock_iothread_prepare(),
Peter Xu <=
- [PATCH 7/8] memory: Assert on no ongoing memory transaction before release BQL, Peter Xu, 2020/04/21
- [PATCH 8/8] memory: Delay the transaction pop() until commit completed, Peter Xu, 2020/04/21