qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/4] bamboo, sam460ex: Tidy up error message for unsupport


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 3/4] bamboo, sam460ex: Tidy up error message for unsupported RAM size
Date: Wed, 22 Apr 2020 16:22:50 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 4/22/20 3:48 PM, Markus Armbruster wrote:
Improve

     $ ppc-softmmu/qemu-system-ppc -M sam460ex -m 4096
     qemu-system-ppc: Max 1 banks of 2048 ,1024 ,512 ,256 ,128 ,64 ,32 MB 
DIMM/bank supported
     qemu-system-ppc: Possible valid RAM size: 2048

to

     qemu-system-ppc: at most 1 bank of 2048, 1024, 512, 256, 128, 64, 32 MiB 
each supported
     Possible valid RAM size: 1024 MiB

Thanks,

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


Signed-off-by: Markus Armbruster <address@hidden>
---
  hw/ppc/ppc4xx_devs.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/ppc/ppc4xx_devs.c b/hw/ppc/ppc4xx_devs.c
index 3376c43ff5..f1651e04d9 100644
--- a/hw/ppc/ppc4xx_devs.c
+++ b/hw/ppc/ppc4xx_devs.c
@@ -716,11 +716,11 @@ void ppc4xx_sdram_banks(MemoryRegion *ram, int nr_banks,
          for (i = 0; sdram_bank_sizes[i]; i++) {
              g_string_append_printf(s, "%" PRIi64 "%s",
                                     sdram_bank_sizes[i] / MiB,
-                                   sdram_bank_sizes[i + 1] ? " ," : "");
+                                   sdram_bank_sizes[i + 1] ? ", " : "");
          }
-        error_report("Max %d banks of %s MB DIMM/bank supported",
-            nr_banks, s->str);
-        error_report("Possible valid RAM size: %" PRIi64,
+        error_report("at most %d bank%s of %s MiB each supported",
+                     nr_banks, nr_banks == 1 ? "" : "s", s->str);
+        error_printf("Possible valid RAM size: %" PRIi64 " MiB \n",
              used_size ? used_size / MiB : sdram_bank_sizes[i - 1] / MiB);
g_string_free(s, true);





reply via email to

[Prev in Thread] Current Thread [Next in Thread]