[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] accel/tcg: Add stub for probe_access()
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] accel/tcg: Add stub for probe_access() |
|
Date: |
Thu, 23 Apr 2020 10:17:36 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 23/04/20 10:04, David Hildenbrand wrote:
>> I can only recommend you to read the thread after this previous patch,
>> as I don't have the knowledge to explain...:
>> https://www.mail-archive.com/address@hidden/msg689115.html
> Yeah, me neither. Sounds wrong to me to have TCG-only code stick around
> in !CONFIG_TCG builds. But I am pretty sure ARM people know what they
> are doing.
It's better if helpers are left out via obj-$(CONFIG_TCG), but it's not
the end of the world if they aren't---as long as it compiles of course!
This case is definitely borderline.
Paolo